From nobody Thu Jan 20 17:18:20 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9282118425FF for ; Thu, 20 Jan 2022 17:18:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jfq3J1x1Wz3jg3 for ; Thu, 20 Jan 2022 17:18:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2009041DA for ; Thu, 20 Jan 2022 17:18:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 20KHIKZn097836 for ; Thu, 20 Jan 2022 17:18:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 20KHIKkt097835 for ports-bugs@FreeBSD.org; Thu, 20 Jan 2022 17:18:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261359] x11/cde: build fails on armv7 FreeBSD 13 Date: Thu, 20 Jan 2022 17:18:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@fuz.su X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: cy@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1642699100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IZSp7nebwW8noqa7HAzLbH+wsyaDYyTfSxUnbjJFpBM=; b=xA3E3L5Lz8XgNeFj9esrykhnWnIj1ASRueMELhTPGxzNehEIDt5dBCsQWj+94rKEW2VupW 53Kiv3h0iBtdBFaTQ9rC6aVt9XNzlonxBg+1VugDEAHZDQmAzfABtcMR9O6ATbvge7V5Kj o6teGivmlNRRiaT6m+k6TALIRYSCdY45C3j0fQFlV7jNaADXXnO/T1pFotUwhZS5ovReZH FGWGXPwPMTmQ4WWqmo83jfMdExkRje5HizxCqlmzwTj479lT6/hsJdbiiQggCJYmtr56ae 3AYEw/++UJgaUl8lnZbbn8sI+OtlKwAjw8KeLo6IlgRKrWmrkXSTb4dk9wMjeA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1642699100; a=rsa-sha256; cv=none; b=MCBzSa3QOUl68WktzLYYUmn8Aa+XKc8jjvuADtHdzsHZWT4oDlk/zGe14LwrhyiB3wnJm6 FbBeZFsfHMUfRxISYdUvX5h0E2Jghy3SiD73A4NruO6jy6wuxiO7UTkxLAxVArD0YnVyeC rrqKnYCFvfW0oXOOqTpVfgRk1PrWthVrybW+WqQvGGWBOosVJR9N4Sm+Jc16pgwx4JQvwH Xg5kWNJSKF88uM8NfWPB8FsExp5EDdD+q8NL7oS6yGtvJDu1Lo0AIcn9Df3hoRGDiuDxZZ kRI8rpFG4J0nVGynPzoNzwr/ayiE3uZlSnefjX83AvyTU1t6RcxjFWdxTQPKNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261359 Bug ID: 261359 Summary: x11/cde: build fails on armv7 FreeBSD 13 Product: Ports & Packages Version: Latest Hardware: arm OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: cy@FreeBSD.org Reporter: fuz@fuz.su CC: pkubaj@FreeBSD.org Assignee: cy@FreeBSD.org Flags: maintainer-feedback?(cy@FreeBSD.org) A recent commit [1] broke the build of x11/cde on armv7. This is due to a wrong type for a newly introduced local variable. The offending patch is: --- programs/dtksh/ksh93/src/lib/libast/hash/hashalloc.c.orig 2021-12-13 19:03:46 UTC +++ programs/dtksh/ksh93/src/lib/libast/hash/hashalloc.c @@ -49,6 +49,7 @@ hashalloc(Hash_table_t* ref, ...) va_list* vp =3D va; Hash_region_f region =3D 0; void* handle; + va_listarg tmpval; va_start(ap, ref); @@ -151,7 +152,8 @@ hashalloc(Hash_table_t* ref, ...) va_copy(*vp, ap); vp++; } - va_copy(ap, va_listval(va_arg(ap, va_listarg))); + tmpval =3D va_listval(va_arg(ap, va_listarg)); + va_copy(ap, tmpval); break; case 0: if (vp > va) The build then fails with error messages: /wrkdirs/usr/ports/x11/cde/work/cde-2.4.0/programs/dtksh/ksh93/src/lib/liba= st/hash/hashalloc.c:155:11: error: assigning to 'va_list *' (aka '__builtin_va_list *') from incompatib= le type 'va_list' (aka '__builtin_va_list'); take the address with & tmpval =3D va_listval(va_arg(ap, va_listarg)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ &( ) /wrkdirs/usr/ports/x11/cde/work/cde-2.4.0/programs/dtksh/ksh93/src/lib/liba= st/hash/hashalloc.c:156:4: error: non-const lvalue reference to type '__builtin_va_list' cannot bind t= o a value of unrelated type 'va_list *' (aka '__builtin_va_list *') va_copy(ap, tmpval); ^~~~~~~~~~~~~~~~~~~ /usr/include/sys/_stdarg.h:49:32: note: expanded from macro 'va_copy' #define va_copy(dest, src) __va_copy(dest, src) ^~~~~~~~~~~~~~~~~~~~ /usr/include/sys/_stdarg.h:47:58: note: expanded from macro '__va_copy' #define __va_copy(dest, src) __builtin_va_copy((dest), (src)) ^~~~~ 2 errors generated. Likely, this can be fixed by changing the type of tmpval. I am however completely unfamiliar with the code base and for a lack of comments have no idea what the purpose of this patch is or why it is needed in the first pla= ce, so I don't think I can fix this on my own without further information. [1]: https://cgit.freebsd.org/ports/commit/?id=3Dc66a851d13783558a8fa17ffcf64759= a0c1b5bab --=20 You are receiving this mail because: You are the assignee for the bug.=