[Bug 262092] net/samba413: Improve build time

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262092

            Bug ID: 262092
           Summary: net/samba413: Improve build time
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: timur@FreeBSD.org
          Reporter: chris@chrullrich.net
          Assignee: timur@FreeBSD.org
             Flags: maintainer-feedback?(timur@FreeBSD.org)

Created attachment 231985
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=231985&action=edit
Patch.

Samba's Python-based build system, waf, will with high probability rebuild the
entire source during stage because it does not maintain the order of compiler
arguments. This appears to defeat its own minimal-rebuild logic, and defeats
ccache in most cases.

Patch attached; reducing build time by ~50 %. If ccache is in use, it does not
waste cache space on single-use objects and thereby improves the overall hit
rate of a shared ccache.

Two successive poudriere builds without the patch had port times of 13:18 and
13:22 minutes respectively. With the patch, the times were 6:05 and 5:47
minutes, all measured with "hot" ccache (i.e. the times are for the ccache
lookups only, and the builds without the patch had cache hits for the different
command lines as well).

The upstream distribution's root Makefile already sets PYTHONHASHSEED to avoid
this issue, but the port skips it by invoking waf directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.