[Bug 261891] [NEW PORT] graphics/epsonscan2: scanner engine supporting many Seiko/Epson scanners

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 19 Feb 2022 13:18:33 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261891

--- Comment #31 from J.R. Oldroyd <fbsd@opal.com> ---
(In reply to Tatsuki Makino from comment #30)

Arigato Tatsuki-san for all these suggestions.  I have incorporated them in the
next version, but with some changes.

You missed the "-raspbian" in the arm distfile name.  I also found that, since
I need to alter the distfile names for the extract and install rules, I still
need to keep things like "x86_64" and "i686" in parameter variables rather than
explicitly in the DISTFILE variables.

Understood that PORTREVISION is not needed yet, but I am using it here on three
test systems (e.g., with USB, over the net, etc) and also with Rainer who is
still testing, and it is helpful for us to see which test version is installed
where.  I expect the committer will remove it when we get to that point.

Re the ":archname" names, I've used your "aarch64" for now, but the Linux code
uses "armv7", so should we perhaps be using "armv7" here too?  I am not
familiar with the distinction between these arm architectures.

I am not sure what you mean about setting WRKSRC to some other value?

I have removed the PLIST_SUB from this Makefile, it isn't needed at all.

I have changed the do-install rule completely because, in testing with Rainer,
we discovered that the es2intif program needs additional shared libs which I
had previously installed in the FreeBSD dirs, but which need to be in the Linux
dirs.  Rainer is testing that again now, so I will delay uploading this latest
version until he reports back.

-- 
You are receiving this mail because:
You are the assignee for the bug.