From nobody Thu Feb 03 20:50:16 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4E63819A466F for ; Thu, 3 Feb 2022 20:50:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JqW5P0FfNz3MsT for ; Thu, 3 Feb 2022 20:50:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D94481ED9A for ; Thu, 3 Feb 2022 20:50:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 213KoGps005725 for ; Thu, 3 Feb 2022 20:50:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 213KoGxs005724 for ports-bugs@FreeBSD.org; Thu, 3 Feb 2022 20:50:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 261637] www/rubygem-gollum: Remove unused dependencies Date: Thu, 03 Feb 2022 20:50:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: sirl33tname@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643921417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1NNugdM49iQTXvEQ4LaQEeS6/uAL2pSCBQducWV2gCw=; b=ZrIUawmQhouAiMwrObsihkuTxVzDj4Un+YUVyENSPidrqZcNzKtMdm7Q3SYLaOZtiFUJxq hH3nIHXAWubvzewt/+asO7kgKDyvV8QwMkA4RBhyAFt+RxsCtaXVED4AZqtb2SPnNGuMeN vZzLq8HXZR6EmdtZg7GX9xVG7GpxcmhJA2xbeiMfa8kUPhqeDw6/JI5f94OI6aXOfOPvwk gg2IKRE8i3vdQ6THxP109Zopc8rTLX43lgYsfIM2XLRElLzRKk7i6OUGsDfUwa/275Su8y /UuyuODOq9Zv/54QhZuclGoFl9q3jFkoynbCxyaKWX7ASHUj7zil4sk/1x5OyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643921417; a=rsa-sha256; cv=none; b=iIYvkXIhKmuXsKsfNY36iw90GyTe7BDQzX9c0Ir2VaykMTxs2d6TeBmYuAA/SrYUVN8/M7 KDiObGESTb8otNL13UXa3x2KCbMtqDG/fAPUD1/Sqs1qq7Svt5KhE3H/SLBd7DNtfeBgVZ EUPAbJzVJ4TaaQjzdvs19txvsXdQMOLKv+N6Vis60xKVFTD+yJQHyq7ydMLzWlHojsjsTq jS8FihMSfm9hhODRQUjclmfW4R3zpeZbZDVGAT5LzEyxgwEBdiiOAAk6EzCACIuj6nsNBg 7Hsc79CUMpeK/LS3O7kYuNSPSfvTEEUvvHAtYkhAcqKlGvRNUCjFypK3LtA1KA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261637 --- Comment #3 from Sir l33tname --- Thanks for the feedback! > What are the failure modes / effects, if any Does not affect quarterly i guess since the changes are new. For latest it means you can not use www/rubygem-gollum-lib as standalone. (I don't think that is a use-case since the lib has a very strong coupling = to www/rubygem-gollum) I broke that here: - https://cgit.freebsd.org/ports/commit/?id=3D644d2ef109a340cdf0d19561117db3d= 9e63b52f7 - https://cgit.freebsd.org/ports/commit/?id=3Dfef2fa5fd8a2a9e170be66133e9d535= a9bc6fd4b The default adapter changes with the update from www/rubygem-gollum-grit_adapter10 to www/rubygem-gollum-rugged_adapter and i added it to the wrong port. > Does gollum-lib pass its test suite after patching dependency version spe= c? [1] bundle exec rake test /usr/local/bin/ruby27 -I"lib:lib:test:." /usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3/vendor/ruby/2.7/gem= s/rake-13.0.6/lib/rake/rake_test_loader.rb=20 root@freebsd:/usr/ports/www/rubygem-gollum-lib/work/gollum-lib-5.1.3 # echo= $? 0 I guess yeah also i already use this in my local setup and i guess it works. > Could you confirm QA (portlint, poudriere) for these changes www/rubygem-gollum # portlint WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "USES". 0 fatal errors and 1 warning found. /www/rubygem-gollum-lib # portlint=20 looks fine not sure about the first warning tried to fix it but when i move USES over = the RUN_DEPENDS section i get an other warning. --=20 You are receiving this mail because: You are the assignee for the bug.=