From nobody Sun Dec 18 08:59:49 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NZcGs3WPKz1GxHF for ; Sun, 18 Dec 2022 08:59:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NZcGs2CfSz3FvM for ; Sun, 18 Dec 2022 08:59:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671353989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n3Unu8idU6p8ZMLP9yHbzpPQSSua3/Bn35e+H4SX0EU=; b=Iiu1PDUsJmWUBbAndK2wwENGobtrSHLf4Go64QhGg+Q95gfbqO1SNe9FJMXIlW5fJhxCj6 C2zWkr5CqkJqeGH8jliWLsugs0nyZ6Bv8n83hF3Izuf3PV4CtTDjP4XBYV3sLgfDNLd0PN 5ubBjbJMsJSmKTCFYd5zNBby5JdKq4hNDlMTe5j3u2gp1tbYYUlldWaH9J4QHyx3sJMCT4 kONkke1cZNluTNQxPCxh0y8fmLC8Dc7ZMj5i6FGye8F0b363tC6Rf31FSKGUHfgUfghSpm DFJJxV8NHSHE5UXzyFDuVgBQjXbvq7gir0wNKsaO+FUJyax5VSaXVSEaRjXnsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671353989; a=rsa-sha256; cv=none; b=c6Hf797k4yWp+d2ikH6AfPAijMuY5TXToF54zBRqw5zp9Ogj0JQcUUzmx43BfIapvZYMl9 u6Mo3zd8d4iOGNIRCkPVvseGmdRKOR9YpZYDIKk/RTlOOeY6FgDATaQtYEa5j3t70o7umV jgjHKnTfadGdt9gtykbpq+ztGCdzviwp9UPgcJMYQn0sIxhk62lOiX286/ULeI0bc7kviq dQINaYCl4UinOeWDBlDFV02mOiar42p1U1ghMBwgP/7c/dLyWKWhtXoG65DeVNUl+QZt/C sIIfhGhqOYYO/axW8zmNULCK4rq4XUc9s/vnqlZyAxB0/7pTIgFjttlV94n23g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NZcGs1B83z1PRp for ; Sun, 18 Dec 2022 08:59:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2BI8xn1W048312 for ; Sun, 18 Dec 2022 08:59:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2BI8xn65048311 for ports-bugs@FreeBSD.org; Sun, 18 Dec 2022 08:59:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 268024] .hooks/pre-commit.d/check_portepoch broken on lines affecting PORTEPOCH comments Date: Sun, 18 Dec 2022 08:59:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268024 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D414b5c61645669a346fc817e0b5852c= 265b96187 commit 414b5c61645669a346fc817e0b5852c265b96187 Author: Matthias Andree AuthorDate: 2022-11-27 12:51:51 +0000 Commit: Tobias C. Berner CommitDate: 2022-12-18 08:58:17 +0000 .hooks/pre-commit.d: unbreak EPOCH checker dns/dnsmasq-devel as of 2.88rc3 contained a comment about PORTEPOCH, which I removed in the 2.88rc5. This tripped up the checker because it assumed that if git yielded lines containing PORTEPOCH, then it must have been PORTEPOCH=3D or similar lines. Untrue in my case. It was printing [pre-commit] dropped PORTEPOCH in dns/dnsmasq-devel/Makefile To solve, only pick out PORTEPOCH diffs that are actual assignments, and if the new PORTEPOCH is empty, and the old one is also, ignore this condition (previously we would exit 1, which is bogus). Also, grep without -E should not have \ in front of - or +. FreeBSD 13.1 grep is fine, but GNU grep ignores those backslashes noisily (and I have prepended it to PATH) and emits warnings. PR: 268024 .hooks/pre-commit.d/check_portepoch | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=