[Bug 213890] Mk/bsd.port.mk: CONFLICTS_INSTALL also blocks targets other than "install"

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 26 Aug 2022 09:04:21 UTC

--- Comment #6 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:


commit acf5d2725a4e221a2aceb44297e151dc3902735d
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2022-08-26 08:52:51 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2022-08-26 09:03:31 +0000

    CONFLICTS_INSTALL: check later for conflicts

    Until now, the check of the CONFLICTS_INSTALL was done during the sanity
    check, meaning very early in the package building process.

    this makes it painful in 2 cases:
    1. a port depend at build time on the extraction of this port, it will
       its warning message along with the default timer, while we will never
       the said conflict at all.
    2. since the ports tree has been staged, one can even go up to create a
       package even if a locally conflicting package is locally installed.

    This change make the check and print of the conflicts only happen during
    install phase, the same way the ports tree checks if a previous version is
    already installed.

    PR:     213890
    Discussed with: tcberner
    Reviewed by:    tcberner
    Differential Revision:  https://reviews.freebsd.org/D36355

 Mk/bsd.port.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

You are receiving this mail because:
You are on the CC list for the bug.