[Bug 265651] [NEW PORT] archivers/zpaqfranz: versioned/snapshot archive

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265651

Felix Palmen <zirias@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zirias@freebsd.org

--- Comment #1 from Felix Palmen <zirias@freebsd.org> ---
Thanks for submitting a port!

A few things require changes though:

* Never set WRKSRC to WRKDIR. Instead, for an upstream distfile that doesn't
create a subdir itself, set NO_WRKSUBDIR=yes.

* Never define do-build and do-install targes if upstream already provides a
build system that can do them (which is the case here).

* Always remove -march=native (you will need to patch the upstream Makefile for
that). Packages must only contain generic binary code that works on every
machine.

* Similar for CPU features, you're checking for SSE2 on the building machine,
but if the executing machine doesn't have it, it will fail. In general, you
can't assume SSE2 on i386.

* The upstream Makefile installs the same binary twice. Remove one of them. If
the second name is really strictly needed, replace it with a symlink.

---

A simple fixed port could look like this:

1) remove everything in the port Makefile starting with WRKSRC= ... Instead
just use this:

NO_WRKSUBDIR=  yes
CFLAGS+=       -DNOJIT


2) add a local patch for upstream's Makefile, removing the -march=natice and
also the second install command. If necessary replace it with a symlink, e.g.
like this:

       ln -s zpaqfranz ${DESTDIR}${BINDIR}/dir

-- 
You are receiving this mail because:
You are the assignee for the bug.