[Bug 265708] Mk/Uses/go.mk: gomod-vendor hits enterprise API limits on AWS repos

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 08 Aug 2022 10:29:06 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265708

            Bug ID: 265708
           Summary: Mk/Uses/go.mk: gomod-vendor hits enterprise API limits
                    on AWS repos
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: dch@freebsd.org
                CC: ports-bugs@FreeBSD.org

Updating e.g. net/seaweedfs to 3.19 requires using the new `M2T_GITHUB` env
var to fetch repos. However this is insufficient for some repos, for example
aws/aws-sdk-go-v2 returns:

getting refs for aws/aws-sdk-go-v2: apis.get
https://api.github.com/repos/aws/aws-sdk-go-v2/git/refs/tags: 502,

It appears to be a limit *on the requested repo*  as all the prior calls work,
just the AWS ones fail. Re-running these requests from a different IP, with a
different Github account's API key, hits the same limit.

https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting

> For requests to resources that belong to an enterprise account on GitHub.com,
> GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests
> per hour per repository.

...
$ cd /usr/ports/net/seaweedfs
$ sed -E -i '' -e 's/^PORTREV.*//' -e 's/2.81/3.19/' Makefile
$ truncate -s 0  distinfo Makefile.deps
$ make makesum
$ env M2T_DEBUG=1 M2T_GITHUB=$YOU:TOKEN make gomod-vendor | tee Makefile.new  
...
cznic:strutil:5f824aabbbe044946f35921791abccfe3b1eafe1:cznic_strutil/vendor/modernc.org/strutil
\
               
cznic:token:46658f20d51b8d0b6c4c551c363c8510c30c2a72:cznic_token/vendor/modernc.org/token

                # Errors found during processing:
                #       error getting refs for aws/aws-sdk-go-v2: apis.get
https://api.github.com/repos/aws/aws-sdk-go-v2/git/refs/tags: 502, body: {
  "message": "Server Error"
}
...
```

Is this an issue with gomod-vendor, github api limits?

I has asked github to clarify, will report back here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.