[Bug 265646] net-im/signal-desktop: Requires wrong node version, pulls packages from network during build

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 05 Aug 2022 12:52:39 UTC

            Bug ID: 265646
           Summary: net-im/signal-desktop: Requires wrong node version,
                    pulls packages from network during build
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: mikael@FreeBSD.org
          Reporter: ltning-freebsd@anduin.net
             Flags: maintainer-feedback?(mikael@FreeBSD.org)
          Assignee: mikael@FreeBSD.org


thanks for creating this port.

I am unable to build it without modifications; there are two main issues:
- It requires specific versions of node (and perhaps other things), when it
should only require that nodeXX is installed.
- It requires network access during build, which breaks building with Poudriere

First error:
  error signal-desktop@5.52.0: The engine "node" is incompatible with
  this module. Expected version "16.15.1". Got "16.16.0"

I notice there is a patch file for package.json - would it not be better to
remove node entirely from there, along with whatever else the port itself pulls
in as dependencies?

Second error - requires network access during build:

[5/6] Building fresh packages...
error /wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-Desktop-
5.52.0/node_modules/sharp: Command failed.
Exit code: 1
Command: (node install/libvips && node install/dll-copy && prebuild-
install) || (node install/can-compile && node-gyp rebuild && node
Directory: /wrkdirs/usr/ports/net-im/signal-desktop/work/Signal-
sharp: Detected globally-installed libvips v8.12.2
sharp: Building from source via node-gyp
gyp info it worked if it ends with ok
gyp info using node-gyp@9.0.0
gyp info using node@16.16.0 | freebsd | x64
gyp info find Python using Python version 3.9.13 found at
gyp http GET
gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack FetchError: request to
failed, reason: getaddrinfo EAI_FAIL nodejs.org

Thanks for your efforts,

You are receiving this mail because:
You are the assignee for the bug.