[Bug 265462] security/crowdsec: update to 1.4.1

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265462

--- Comment #4 from Nuno Teixeira <eduardo@FreeBSD.org> ---
Created attachment 235632
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=235632&action=edit
crowdsec-1.4.1 variables fixed v1

Sugestion:

1. switch to DISTVERSION
---
 PORTNAME=      crowdsec
-PORTVERSION=   1.3.4   # NOTE: change BUILD_VERSION and BUILD_TAG as well
-PORTREVISION=  2
 DISTVERSIONPREFIX=     v
+DISTVERSION=   1.4.1   # NOTE: change _BUILD_TAG as well
 CATEGORIES=    security
---

2. remove #GH_TAGNAME comment
   add user varialble _BUILD_TAG (short hash)
---
-GH_TAGNAME=    v1.3.4-freebsd
-#GH_TAGNAME is automatically set from DISTVERSION
+GH_TAGNAME=    v1.4.1-freebsd
+_BUILD_TAG=    527995f
---

3. substitute BUILD_VERSION variable
   substitute BUILD_VERSION variable
---
-MAKE_ENV=      BUILD_VERSION="v1.3.4" \
-               BUILD_TAG="c196ed45b62c12d9c6549da927c37c64bd08c642" \
+MAKE_ENV=      BUILD_VERSION="${DISTVERSIONFULL}" \
+               BUILD_TAG="${_BUILD_TAG}" \
---

Question: since GH_TAGNAME could be a hash of a commit id to do a snapshot, in
this example a commit id, why it is needed to mention hash in BUILD_TAG?

IMO, BUILD_TAG=${GH_TAGNAME} will be sufficient

Could you test it?

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.