[Bug 263159] [NEW PORT] games/solver Math quiz game

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263159

--- Comment #5 from Robert Clausecker <fuz@fuz.su> ---
(In reply to modex from comment #4)

> https://cgit.freebsd.org/ports/tree/graphics/acidwarp/Makefile

Contrary to my expectation, this method works, too (I've just checked).  It's
just somewhat unconventional.  Feel free to leave it the way it is.

> No particular reason. Do you suggest I change this or does this matter?

Yes, please remove the ?= unless there is a specific reason to keep it. 
Generally, ?= should be used if the variable is one the user is expected to
set, such as CFLAGS.  LIB_DEPENDS is not such a variable.

> It is the nature of svgalib. For a non-root user to use an svgalib application this must be set.

This makes sense.  Consider changing the description of the SETUID option in a
way  that this is clear.  E.g.  "Install setuid root to access VGA device" or
something.

>  I will give this a shot as well and re-upload the shar with the changes. Thank you.

Note that if you switch to using git correctly (i.e. having the source files in
git, not the tarball), then this won't be needed.  When github generates
tarballs (which you can use using USE_GITHUB), it automatically puts in a top
level directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.