From nobody Wed Apr 20 15:14:43 2022 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9AB7813A5565 for ; Wed, 20 Apr 2022 15:14:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kk4366qnkz3pxd for ; Wed, 20 Apr 2022 15:14:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id CB345162C4 for ; Wed, 20 Apr 2022 15:14:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23KFEgWE001915 for ; Wed, 20 Apr 2022 15:14:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23KFEgw6001914 for ports-bugs@FreeBSD.org; Wed, 20 Apr 2022 15:14:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 263159] [NEW PORT] games/solver Math quiz game Date: Wed, 20 Apr 2022 15:14:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: modex@danwin1210.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650467683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8iWapkVlH+vTXMVh4ffJhALjruM2RT4pBvG8HbsoHMs=; b=nAqVFmD0HSdCQSKiJaiEEf4KycG9AFjuEoBc3g/hxK4epfhJqzr7nLmTweSslqXPKk7F6e YU6q3tO8t+JoEDuu3WrJRBBTBo+essSOUq0chqAQAd6t5WSf6WPputEwRdonxx+6+AwQR7 cihOTQqYV+XH9Hc4rlmOUm9NehkR2nOticlc6tigNLaASVBtABIw+eqd5oH6GaiQtN5f3G 4oh/zxvr+ludDJacrYlKcbKGWK09rXor3iQpqFxrehIOyzkzbD5SoyMKT8gozP1yn4kr1q kTji6PnLvzkC14CdOy3bl05mQTTrNDD7h0atBUn1ZaYbLaby2at+6o164AX9Ig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650467683; a=rsa-sha256; cv=none; b=mnfpys/oxysUtwJMlkt9WJPl30rBDOtsMN0UKbzewNYLDTGFwkcFf6jtg351GiByHyIXWK ZEGT+W4qQoFNkDf1Ky/TCdlTL8lzWQtyu+oo0OHT7MMvzf1HFWD1TAiSTjACRxd4xlRtXn jc8WGKILfq0YltEla8EGD4rRNANWiTEPLWtnTRkvKgR6e3mk72XYjcJWEl3wKKmTmdEvay v/ofJ1ahNNU9g7imkyerT/lMxXsvdEw9mH6ZzGhZjahZoEDqRMvFKGDOQqfZILOMbeaw6y Qd84N6QWW1RtGJVv3z7XFGsNsdEgHvsZAXKGMn1xHJdssFdQ+cm7YsUHKoGoiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263159 --- Comment #4 from modex@danwin1210.de --- Hi, I suppose this is your project. - Correct. My info should be in the Makefile, thought please let me know if= it is incorrect. Please consider fixing the git repository so it actually contains the source files, not an archive of them. Then tag a release and use USE_GITHUB to specify the master site. - Ok, understood. As for LIB_DEPENDS, why do you use ?=3D ? Is there any particular reason? - No particular reason. Do you suggest I change this or does this matter? The SETUID logic is not going to work the way you envision it; setuid bits = must be specified in the plist. Instead use the pattern found in sysutils/cdrto= ols for this purpose. - I am using it in the same manner as another port: https://cgit.freebsd.org/ports/tree/graphics/acidwarp/Makefile The port also uses svgalib. I see the SETUID in cdrtools and can make that change: https://cgit.freebsd.org/ports/tree/sysutils/cdrtools/Makefile Why do you need Setuid functionality anyway? In any way, ports that setuid have to be treated with care as they are a potential security risk. - It is the nature of svgalib. For a non-root user to use an svgalib application this must be set. Make sure to consistently use ${...} instead of $(...) in the port Makefile. - Understood. I can make this change. I see where i have (CC) and such. Your distribution file seems to have no top level directory. Use NO_WRKSUB= DIR to have the ports system create one for you. Do not set WRKSRC in this case and change your do-build and do-install targets to take source files from WRKSRC, not WRKDIR.c - I will give this a shot as well and re-upload the shar with the changes. Thank you. --=20 You are receiving this mail because: You are the assignee for the bug.=