[Bug 263159] [NEW PORT] games/solver Math quiz game

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263159

--- Comment #2 from Robert Clausecker <fuz@fuz.su> ---
Hi,

I suppose this is your project.

Please consider fixing the git repository so it actually contains the source
files, not an archive of them.  Then tag a release and use USE_GITHUB to
specify the master site.

The current approach is not forbidden, but it's certainly very unconventional.

As for LIB_DEPENDS, why do you use ?= ?  Is there any particular reason?

The SETUID logic is not going to work the way you envision it; setuid bits must
be specified in the plist.  Instead use the pattern found in sysutils/cdrtools
for this purpose.

Why do you need Setuid functionality anyway?  In any way, ports that setuid
have to be treated with care as they are a potential security risk.

If it is for score files, put the binary into the games group and setgid it. 
Install blank scores file using the @sample mechanism into the appropriate
location (see games/nbsdgames for an example) such that they are writable to
the games user.

If it is for accessing the screen, I'm not sure if setuid is appropriate. 
Check if one of the groups video, operator, or wheel do the trick, too.  I
forgot how exactly this works.  Also consider porting your code to a library
that works on X11 such as SDL2.

Make sure to consistently use ${...} instead of $(...) in the port Makefile.

Your distribution file seems to have no top level directory.  Use NO_WRKSUBDIR
to have the ports system create one for you.  Do not set WRKSRC in this case
and change your do-build and do-install targets to take source files from
WRKSRC, not WRKDIR.c

-- 
You are receiving this mail because:
You are the assignee for the bug.