[Bug 263163] games/xboard: with default of no engine installed, xboard errors out on empty -firstChessProgram in xboard.conf

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263163

            Bug ID: 263163
           Summary: games/xboard: with default of no engine installed,
                    xboard errors out on empty -firstChessProgram in
                    xboard.conf
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: pauamma@gundo.com
                CC: mbeis@xs4all.nl
             Flags: maintainer-feedback?(mbeis@xs4all.nl)
                CC: mbeis@xs4all.nl

The immediate cause seems to be in Makefile target post-patch, which includes:

        @firstEngine=`cat ${WRKSRC}/firstEngine.txt` && \
         ${REINPLACE_CMD} -e "s|\(-firstChessProgram\) .*|\1 $${firstEngine}|"
${XBOARDCONF}

"OPTIONS_DEFAULT?=       XAW" doesn't include any engine, which leaves that
line empty instead of the upstream setting "-firstChessProgram fairymax".

I'm not sure whether the best fix is to make it depend on one engine by default
or to have a pkg-message saying "install one manually and adjust xboard.conf to
match", but I'm leaning toward the former since that's what upstream does.

Reported in #freebsd-bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.