[Bug 258674] x11/elementary-terminal: Avoid linuxism

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258674

            Bug ID: 258674
           Summary: x11/elementary-terminal: Avoid linuxism
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: nc@FreeBSD.org
          Reporter: duchateau.olivier@gmail.com
          Assignee: nc@FreeBSD.org
             Flags: maintainer-feedback?(nc@FreeBSD.org)

Created attachment 228119
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=228119&action=edit
Fix linuxism

Original author is amdmi3@ (Dmitry Marakasov) [1] and this port was deleted [2]
(even if it was another name, we should adjust MOVED file).

Line: libvte-2.91.so:x11-toolkits/vte3 should be replaced by USE_GNOME= vte3

io.elementary.terminal looks for /proc, so we need linprocfs(5) enabled (see
pkg-message.in file).

In src/Widgets/TerminalWidget.vala there is a command, which requires dbus
(dbus-send), this utility is deprecated, we should use gdbus (from
devel/glib20). Moreover it uses specific builtin bash. It is better to avoid to
export this command (other shells completion are wrong).

io.elementary.terminal exposes io.elementary.terminal service (only available
for this terminal, (see [3] line 23), we have better tool with procstat(1). So
we can delete the 'PROMPT_COMMAND' environment variable. I wonder if
'PANTHEON_TERMINAL_ID' is still usefull. I try dbus-send (and gdbus call)
commands, none work!

In file settings, we provide generic font, otherwise contains of
io.elementary.terminal is ugly (at least on my xfce session with default Gtk
theme)

Based on my own port [4].

[1] https://cgit.freebsd.org/ports/tree/x11/pantheon-terminal/Makefile?h=2019Q1
[2] https://cgit.freebsd.org/ports/tree/MOVED#n11572
[3] https://github.com/elementary/terminal/blob/6.0.0/src/DBus.vala#L23
[4]
https://codeberg.org/olivierd/freebsd-ports-elementary/src/branch/6.0/x11/elementary-terminal

-- 
You are receiving this mail because:
You are the assignee for the bug.