[Bug 258631] dns/opendnssec2: Update to 2.1.10

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258631

--- Comment #4 from Nuno Teixeira <eduardo@FreeBSD.org> ---
(In reply to Jaap Akkerhuis from comment #2)
Remember that portlint, portclippy and portfmt are tools that we do not have to
follow blindly like any other tool.

1. portlint: OK

2. portclippy Makefile:
---
# PORTNAME block
PORTNAME
DISTVERSION
CATEGORIES
MASTER_SITES
PKGNAMESUFFIX

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE
LICENSE_FILE

# Dependencies
BUILD_DEPENDS
LIB_DEPENDS

# USES block
USES
USE_RC_SUBR

# Configure block
GNU_CONFIGURE
CONFIGURE_ARGS

# Make block
+INSTALL_TARGET
-SUB_FILES

# Conflicts
CONFLICTS

# Standard bsd.port.mk variables
+SUB_FILES

# Users and groups block
USERS
GROUPS

# Options definitions
OPTIONS_DEFINE
OPTIONS_DEFAULT
-OPTIONS_SUB
OPTIONS_SINGLE
OPTIONS_SINGLE_DB
+OPTIONS_SUB

# Options descriptions
+MYSQL_DESC
SOFTHSM_DESC
-MYSQL_DESC
SQLITE_DESC

# Options helpers
+MYSQL_USES
MYSQL_CONFIGURE_ON
+SOFTHSM_RUN_DEPENDS
+SOFTHSM_CONFIGURE_ON
+SQLITE_BUILD_DEPENDS
-MYSQL_USES
SQLITE_USES
SQLITE_CONFIGURE_ON
-SQLITE_BUILD_DEPENDS
-SOFTHSM_CONFIGURE_ON
-SOFTHSM_RUN_DEPENDS

-INSTALL_TARGET
---
Seems fine to me this changes

3. portfmt -D Makefile:
---
--- Makefile
+++ Makefile
@@ -31,23 +31,22 @@
 GROUPS=                opendnssec

 PORTDOCS=      MIGRATION NEWS README.md
-MIGRATE=       README.md find_problematic_zones.sql \
-               convert_mysql mysql_convert.sql \
-               convert_sqlite sqlite_convert.sql
+MIGRATE=       README.md find_problematic_zones.sql convert_mysql \
+               mysql_convert.sql convert_sqlite sqlite_convert.sql
 CONVERT=       convert_mysql_to_sqlite convert_sqlite_to_mysql
 SCHEMAS=       schema.mysql schema.sqlite

-OPTIONS_DEFINE=                SOFTHSM DOCS
+OPTIONS_DEFINE=                DOCS SOFTHSM
 OPTIONS_DEFAULT=       SQLITE
 OPTIONS_SUB=           yes

 OPTIONS_SINGLE=                DB
-OPTIONS_SINGLE_DB=     SQLITE MYSQL
+OPTIONS_SINGLE_DB=     MYSQL SQLITE

-SOFTHSM_DESC=          SoftHSM cryptographic store for PKCS \#11 interface
+SOFTHSM_DESC=  SoftHSM cryptographic store for PKCS \#11 interface

-MYSQL_DESC=            Use MYSQL backend
-SQLITE_DESC=           Use SQLite backend
+MYSQL_DESC=    Use MYSQL backend
+SQLITE_DESC=   Use SQLite backend

 MYSQL_CONFIGURE_ON=    --with-enforcer-database=mysql
 MYSQL_USES=            mysql
@@ -59,7 +58,7 @@
 SOFTHSM_CONFIGURE_ON= 
--with-pkcs11-softhsm=${LOCALBASE}/lib/softhsm/libsofthsm2.so
 SOFTHSM_RUN_DEPENDS=   softhsm2>=2.5.0:security/softhsm2

-INSTALL_TARGET=                install-strip
+INSTALL_TARGET=        install-strip

 pre-build:
        ${REINPLACE_CMD} -e "s|\(-lcrypto\)|-L${OPENSSLLIB} \1|g" \
---
- MIGRATE part is ok with better look at 72 columns
- OPTIONS_DEFINE is ok with alphabetical order
- OPTIONS_SINGLE_DB is ok with alphabetical order
- TABS are optional

portfmt is a bit tricky and I always be carefull with this tool.

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.