[Bug 258397] biology/jellyfish: fix unused variable warning with clang 13

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 09 Sep 2021 21:56:32 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258397

            Bug ID: 258397
           Summary: biology/jellyfish: fix unused variable warning with
                    clang 13
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: jwb@freebsd.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(jwb@freebsd.org)
          Assignee: jwb@freebsd.org

During an exp-run for llvm 13 (see bug 258209), it turned out that
biology/jellyfish fails to build with clang 13 [1]:

In file included from sub_commands/count_main.cc:38:
In file included from ./include/jellyfish/hash_counter.hpp:16:
./include/jellyfish/dumper.hpp:48:24: error: variable 'mode' set but not used
[-Werror,-Wunused-but-set-variable]
    std::ios::openmode mode = std::ios::out;
                       ^
1 error generated.

This is an actual bug: the mode variable is setup in the
dumper_t::open_next_file() function, but never used for actually opening the
output file.

Fix this by adding the mode argument to the out.open() call.

[1]
http://gohan04.nyi.freebsd.org/data/mainamd64PR258209-default/2021-09-05_20h27m09s/logs/errors/Jellyfish-2.3.0.log

-- 
You are receiving this mail because:
You are the assignee for the bug.