[Bug 258294] security/suricata: Respect CC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258294

--- Comment #2 from Evgeniy Khramtsov <evgeniy@khramtsov.org> ---
(In reply to Kubilay Kocak from comment #1)

> Are environment/user CFLAGS and other flags (LDFLAGS, etc) honoured?

Yes. Checked via build log:

[...]
 #### /usr/local/etc/poudriere.d/130-amd64-make.conf ####
-CFLAGS+=-O0
-LDFLAGS+=-Wl,--as-needed
+CFLAGS+=-O3
+LDFLAGS+=-Wl,--no-as-needed
[...]
-  CFLAGS                                   -O2 -pipe -O0 
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing 
-DOS_FREEBSD -std=c11 -I${srcdir}/../rust/gen -I${srcdir}/../rust/dist
+  CFLAGS                                   -O2 -pipe -O3 
-fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing 
-DOS_FREEBSD -std=c11 -I${srcdir}/../rust/gen -I${srcdir}/../rust/dist
[...]
-/bin/sh ../../libtool  --tag=CC   --mode=link cc -I../.. -D_GNU_SOURCE -g
-Wall -Wextra -std=gnu99 -pedantic -Wextra -Wno-missing-field-initializers
-Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes
-Wno-unused-parameter -O2 -pipe -O0  -fstack-protector-strong -isystem
/usr/local/include -fno-strict-aliasing  -O2 -Wstrict-overflow=1
-fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -fPIC 
-Wl,--as-needed -fstack-protector-strong  -L/usr/local/lib -o liblzma-c.la   
LzFind.lo LzmaDec.lo  -lz -L/usr/local/lib
+/bin/sh ../../libtool  --tag=CC   --mode=link cc -I../.. -D_GNU_SOURCE -g
-Wall -Wextra -std=gnu99 -pedantic -Wextra -Wno-missing-field-initializers
-Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes
-Wno-unused-parameter -O2 -pipe -O3  -fstack-protector-strong -isystem
/usr/local/include -fno-strict-aliasing  -O2 -Wstrict-overflow=1
-fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -fPIC 
-Wl,--no-as-needed -fstack-protector-strong  -L/usr/local/lib -o liblzma-c.la  
 LzFind.lo LzmaDec.lo  -lz -L/usr/local/lib
[...]

I didn't expose rust related build log via cargo.mk verbosity due to
unfamiliarity with cargo, though the difference can be observed via build speed
(-O0 vs -O3):

[...]
    Compiling suricata v6.0.3
(/wrkdirs/usr/ports/security/suricata/work/suricata-6.0.3/rust)
-    Finished release [optimized + debuginfo] target(s) in 39.10s
+    Finished release [optimized + debuginfo] target(s) in 36.99s
[...]

> needs-qa

Can you clarify what QA does this change need? This port does not have
consumers
and I already did QA on Tier 1 platforms and made sure that the package
contents did not change.

-- 
You are receiving this mail because:
You are the assignee for the bug.