[Bug 258254] www/chromium: unbreak for i386
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 03 Sep 2021 16:30:27 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258254 Bug ID: 258254 Summary: www/chromium: unbreak for i386 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: chromium@FreeBSD.org Reporter: firstname.lastname@example.org Assignee: chromium@FreeBSD.org Flags: maintainer-feedback?(chromium@FreeBSD.org) Created attachment 227648 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=227648&action=edit unbreak on i386 Find attached my suggestion how to unbreak the build for i386 (patch applies with `git am`). The commit message should explain it: --- www/chromium: unbreak on i386 FreeBSD's sendfile() expects a pointer to off_t for returning the copied size. Change local variables used to off_t for OS_BSD: if any, this is wider than the ssize_t used before (on amd64, it's the same). --- I *think* this change would be correct for any arch, but please challenge/review my reasoning. Disclaimer: PR created on an old EeePC using the i386 build of chromium 92.0.4515.159_1 -- in the hope the changed code path is actually used for attaching the patch here, but TBH, I have no idea whether this really is the case. I also needed to increase kern.maxtsiz for running chromium. -- You are receiving this mail because: You are the assignee for the bug.