[Bug 259332] net/pyrad: Update to 2.4

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259332

Kai Knoblich <kai@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |kai@FreeBSD.org
           Assignee|ports-bugs@FreeBSD.org      |kai@FreeBSD.org
                URL|                            |https://github.com/pyradius
                   |                            |/pyrad/releases/tag/2.4

--- Comment #2 from Kai Knoblich <kai@FreeBSD.org> ---
Thank you for the patch, Gian-Simon!  A few items for review:

* The "setup.py" has "install_requires=['six', 'netaddr']", so "RUN_DEPENDS"
needs to be added and set accordingly.  (Just loading the Python module via
"import pyrad" doesn't cause any errors without those dependencies).

* Adding a "do-test" target will improve future QA and can catch issues with
missing or incompatible dependencies.

* The examples files that are installed via the EXAMPLES options are still
present in the upstream repository but aren't added to the sdist package.
Switching to USE_GITHUB for a while until upstream re-add the examples to the
sdist should fix this.  In that case LICENSE_FILE can be used as well, because
the license file isn't available in the sdist, yet.


For the case, if the EXAMPLES option should stay (which I would prefer, IMHO):

* The install target for the EXAMPLES option can be modernized via
"post-install-EXAMPLES-on".

* Add "concurrent" to "USE_PYTHON" to make the package concurrent safe, as it
installs the example files to $PREFIX/share/examples/pyXX-pyrad" (= XX Python
flavor) instead $PREFIX/share/examples/pyrad"


Would you like to update your patch and add the above items? If not, it's not a
problem either, in this case I'd add the items before committing the update.

-- 
You are receiving this mail because:
You are the assignee for the bug.