[Bug 259005] Mk/Scripts/qa.sh: Spurious SONAME warnings due to pipefail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259005

            Bug ID: 259005
           Summary: Mk/Scripts/qa.sh: Spurious SONAME warnings due to
                    pipefail
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
               URL: https://reviews.freebsd.org/D31211
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: henrik@gulbra.net

Created attachment 228517
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=228517&action=edit
qa_soname_pipefail.diff

The recently added "set -o pipefail" at the top of Mk/Scripts/qa.sh
breaks the exit status for pipelines where long texts are piped into
"grep -q", as explained in the comments for PR 167009 and elaborated
on elsewhere ( https://reviews.freebsd.org/D31211 ).

This produces lots of incorrect SONAME warnings during stage-qa for
at least some ports and systems. I have been waiting for someone to
patch this, but since the problem still exists in the current tree,
it is probably best to offer my own patch, if only to have an open
bug report for the issue.

There are other instances of the "| grep -q" pattern in qa.sh, but it
looks like the remaining examples have single-line input texts, which
are unlikely to trigger this bug. I think we can keep those unchanged.

-- 
You are receiving this mail because:
You are the assignee for the bug.