[Bug 258846] devel/dyncall: unbreak on arm

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 01 Oct 2021 16:45:04 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258846

--- Comment #3 from Tassilo Philipp <tphilipp@potion-studios.com> ---
(In reply to Robert Clausecker from comment #2)

> ... so I wonder why this one file diverges.

Good question... no idea. Maybe there was a reason, maybe there wasn't, this
all started a long time ago in 2008...
Of course this should work everywhere, so will make it work everywhere. :)

> Also consider migrating to UAL (.syntax unified) if possible.

Absolutely. I'll try and if that works on the platforms we plan to still
support, yes, of course.

> As for the patches, I can confirm that the resulting code also assembles when using gcc/GNU as.

Thanks!

> The test suite is not ran automatically by any part of the package building process.  Setting TEST_TARGET simply means that it is possible to run "make test" on the port.  However, if you don't feel comfortable with that, there's no problem leaving it out.

I want to have that in, eventually, for sure, so I'll play around with it and
see if it makes sense at this point.


Thanks again, I'll get back to you asap. I'll integrate the changes into
dyncall directly, for an upcoming 1.3 release. That release might still be a
little ways out, though, so I consider getting your patches into the ports
tree, as-is, for v1.2.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.