[Bug 258846] devel/dyncall: unbreak on arm

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 01 Oct 2021 15:57:50 UTC

--- Comment #2 from Robert Clausecker <fuz@fuz.su> ---
(In reply to Tassilo Philipp from comment #1)

Hi Tassilo,

ARM does not normally use % sigils for registers and I think gas just accepts
them out of courtesy.  Clang's assembler on the other hand is a lot stricter. 
I none of your other arm assembly source files in your projects have them, so I
wonder why this one file diverges.

Also consider migrating to UAL (.syntax unified) if possible.  This'll avoid a
lot of headache in the future.

It is possible that your clang is configured to use the GNU assembler for
assembly files.

As for the patches, I can confirm that the resulting code also assembles when
using gcc/GNU as.

> I'm not sure about the use of hooking up the test suite *in its current state*, as some test executables do not return any meaningful status codes. This is also on my list to fix. Of course this should be hooked up eventually, so you did the right thing, I just think the suite needs some changes, first.

The test suite is not ran automatically by any part of the package building
process.  Setting TEST_TARGET simply means that it is possible to run "make
test" on the port.  However, if you don't feel comfortable with that, there's
no problem leaving it out.

You are receiving this mail because:
You are the assignee for the bug.