[Bug 259957] ports-mgmt/portlint: Don't warn about "possible direct use of command" in PORTNAME

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=259957

            Bug ID: 259957
           Summary: ports-mgmt/portlint: Don't warn about "possible direct
                    use of command" in PORTNAME
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus@FreeBSD.org
          Reporter: gerald@FreeBSD.org
          Assignee: marcus@FreeBSD.org
             Flags: maintainer-feedback?(marcus@FreeBSD.org)

Created attachment 229627
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=229627&action=edit
Proposed patch

Running portlint in devel/patch issues a false positive:

  % cd $PORTSDIR/devel/patch
  % portlint -C
  WARN: Makefile: [1]: possible direct use of command "patch" found. use
${PATCH} instead.
  make: Unknown modifier 'd'

Apart from the line number being off (this is not about the first line)
this warns about 

  PORTNAME=  patch

that is, the name of the port - which clearly is not a use of the command
patch as such.

The proposed patch addresses it. 

(Any ideas on the wrong line number and the "make: Unknown modifier 'd'"
note?)

-- 
You are receiving this mail because:
You are the assignee for the bug.