From nobody Thu May 27 02:53:48 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B8776BF59F7 for ; Thu, 27 May 2021 02:53:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FrC7c4kwLz3NWc for ; Thu, 27 May 2021 02:53:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8C4431C7B9 for ; Thu, 27 May 2021 02:53:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14R2rmvI017444 for ; Thu, 27 May 2021 02:53:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14R2rm4c017443 for ports-bugs@FreeBSD.org; Thu, 27 May 2021 02:53:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 255670] Mk/Keywords/sample.ucl: Deleting any configuration files automatically is a bug Date: Thu, 27 May 2021 02:53:48 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dave@jetcafe.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255670 --- Comment #9 from dave@jetcafe.org --- (In reply to Adam Weinberger from comment #8) > Removing the file isn=E2=80=99t the problem, so while this patch would wo= rk around it, > it doesn=E2=80=99t address the underlying issue. We need to identify how = and when the=20 > files are removed and not recreated. I agree that the underlying issue is not addressed. I would still support t= his patch being included as a policy idea.=20 We have found that actually removing the -dist files prior to the upgrade consistently prevents the deletion of the @sample files, regardless of whet= her they have been edited or not. > Can you provide some more info about your environment?=20 Yes. I build packages with poudriere: # poudriere version 3.3.2-10-g8e54ca5a for all my target sites. Each target site has different options directories= and different package repositories. These streams are not crossed; upgrading a target site always uses the same options directories, package repositories,= and build configuration. When I do these builds, I generally do them against the quarterly ports tree build I've picked at the time. Occasionally I cherry p= ick some ports from HEAD which have needed security upgrades.=20 I use pkg(8) to manage package installations. I've been doing this for seve= ral years with no obvious issues. Each package upgrade goes like this:=20 1) Alter the repository configuration file to point to the new package repo 2) Upgrade pkg first with "pkg upgrade pkg" 3) Then let pkg have it's way with "pkg upgrade" This has always worked before and until this particular upgrade @sample fil= es were not deleted.=20 I did not notice the first instance of file deletion until I discovered that the file fastcgi_params was missing and nginx would not start. It was curio= us to me because I never edited that file (most of my nginx sites are templated and explicitly configured after we include this file).=20 I did not discover this was pkg until -at a different site- the same thing happened.=20 Let me know if you need more information. --=20 You are receiving this mail because: You are on the CC list for the bug.=