[Bug 256736] [bsd.port.mk] [regression] [patch] _FLAVOR_RECURSIVE_SH passes flavor to child make

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256736

            Bug ID: 256736
           Summary: [bsd.port.mk] [regression] [patch]
                    _FLAVOR_RECURSIVE_SH passes flavor to child make
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: otis@FreeBSD.org
          Reporter: ross@ross-williams.net
          Assignee: otis@FreeBSD.org
             Flags: maintainer-feedback?(otis@FreeBSD.org)

Created attachment 225957
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225957&action=edit
Patch

The change introduced in bug #256301 (review D30579), which prevents child make
processes from receiving an empty `FLAVOR` variable when `FLAVOR` should be
unset has the side effect of allowing any `FLAVOR` already in the parent make
process environment to propagate to the child.

The attached patch unsets `FLAVOR` before starting the child make.

Behavior before:
```
    $ make FLAVOR=zabbix54
    ...
    ===>  zabbix54-agent-5.4.1 FLAVOR is defined (to zabbix54) while this port
does not have FLAVORS.
    *** Error code 1
    Stop.
    make[1]: stopped in /usr/ports/net-mgmt/zabbix54-agent
    *** Error code 1
    Stop.
```

Expected behavior after:
```
    $ make FLAVOR=zabbix54
    ...
    ===> Fetching all distfiles required by zabbix54-agent-5.4.1 for building
    $ echo $?
    0
```

-- 
You are receiving this mail because:
You are the assignee for the bug.