[Bug 256612] multimedia/plexmediaserver: rc.d file uncleanly tries to kill nonexistent process

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 15 Jun 2021 00:41:53 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256612

            Bug ID: 256612
           Summary: multimedia/plexmediaserver: rc.d file uncleanly tries
                    to kill nonexistent process
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: feld_at_FreeBSD.org
          Reporter: blue.esper_at_icloud.com
          Assignee: feld_at_FreeBSD.org
             Flags: maintainer-feedback?(feld_at_FreeBSD.org)

the plex_stop_postcmd function in /usr/local/etc/rc.d/plexmediaserver attempts
to kill any leftover child processes, but the kill command runs whether there
are any or not. This makes it run without input if there are no processes to
kill, making it return an error if you restart the plexmediaserver service.
It's benign but unsightly, and I think it should be adjusted a bit to test if
the variable is empty before trying to kill it. Something to the effect of:


        if [ -z ${_PLEX_CHILDREN} ];then
            kill -9 ${_PLEX_CHILDREN}
        fi

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Tue Jun 15 2021 - 00:41:53 UTC

Original text of this message