From nobody Thu Jun 03 03:20:32 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E0F2D136C627 for ; Thu, 3 Jun 2021 03:20:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FwWPD4jFsz3k07 for ; Thu, 3 Jun 2021 03:20:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8660F226C8 for ; Thu, 3 Jun 2021 03:20:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1533KWqQ028659 for ; Thu, 3 Jun 2021 03:20:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1533KWhp028658 for ports-bugs@FreeBSD.org; Thu, 3 Jun 2021 03:20:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256233] security/doas: target user's login class gets ignored Date: Thu, 03 Jun 2021 03:20:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bugs.freebsd@scourger.nl X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256233 --- Comment #13 from bugs.freebsd@scourger.nl --- The suggestion to use "doas -S" or "su -" won't really work in many situati= ons. You can't run arbitrary commands (e.g. when calling doas from a script) and= you can't pass or modify environment variables. Simulating a full login is only useful in fairly specific circumstances (predominantly interactive shell wo= rk). I'm not quite convinced that it's confusing when the language gets switched= . In a way, that was already happening before the fix (always switching to the C locale because no LANG was set). But I guess we will have to agree to disag= ree on this point. When I think about it, I might even prefer the old behaviour (LANG gets cleared) over the new one (default to setting the caller's LANG). The reaso= n is simply that no other environment variable defaults to the caller's value. A= ll others either get cleared or set to the value appropriate for the target us= er. I think you should consider to either revert to the old behaviour (just res= et LANG), or use the language from the target user. I believe using the caller= 's language is just not very favorable from a consistency standpoint. For what it's worth, doas on OpenBSD clears the LANG environment (but it al= so doesn't let you configure "lang" in login.conf). --=20 You are receiving this mail because: You are the assignee for the bug.=