From nobody Tue Jun 01 13:28:19 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DAB73E77753 for ; Tue, 1 Jun 2021 13:28:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FvXzR5ntkz3FZm for ; Tue, 1 Jun 2021 13:28:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AF7732447A for ; Tue, 1 Jun 2021 13:28:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 151DSJOm030145 for ; Tue, 1 Jun 2021 13:28:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 151DSJO9030144 for ports-bugs@FreeBSD.org; Tue, 1 Jun 2021 13:28:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 250335] ports-mgmt/portmaster: tries to build devel/git@lite even if devel/git@default is already installed Date: Tue, 01 Jun 2021 13:28:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: se@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250335 --- Comment #9 from Stefan E=C3=9Fer --- Created attachment 225451 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225451&action= =3Dedit Patch to make conflicts check not ignore same origin packages Another comment regarding the root cause of this issue: CONFLICTS_INSTALL is treated differently in bsd.port.mk and by the pkg comm= and. In bsd.port.mk no output is generated by "make check-install-conflicts" for conflicting packages, if the origin is the same. This is despite all other variants than for the currently built FLAVOR are listed in the *_INSTALL_CONFLICTS variables for each FLAVOR. And since "git" and "git-lite" both have the same origin, "make check-install-conflicts" does not list them as conflicting. The pkg command does not care for the origin, and it detects the conflict. IMHO, the test in bsd.port.mk should be aligned with the one in the pkg com= mand to give an early indication of the conflict that else will only be detected during the install phase. The attached patch does only remove the comparison with $orgn - a more comp= lete patch would remove %o from the pkg query string and orgn from the while loo= p. This patch is only meant to demonstrate the effect on the output of "make check-install-conflicts" and to show that it fixes the issue reported in th= is PR. --=20 You are receiving this mail because: You are the assignee for the bug.=