[Bug 256301] bsd.port.mk: fix setting of FLAVOR in _FLAVOR_RECURSIVE_SH

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 01 Jun 2021 07:18:01 +0000

--- Comment #2 from commit-hook_at_FreeBSD.org ---
A commit in branch main references this bug:


commit e70bedf4f71eda15307b550cefd028a5a4b0281a
Author:     Mathieu Arnold <mat_at_FreeBSD.org>
AuthorDate: 2021-06-01 07:04:25 +0000
Commit:     Mathieu Arnold <mat_at_FreeBSD.org>
CommitDate: 2021-06-01 07:16:35 +0000

    Mk/bsd.port.mk: Don't pass up an empty flavor.

    The classic way to handle flavors is to set:

      FLAVORS= foo bar
      FLAVOR?= ${FLAVORS:[0]}

    And in that case, FLAVOR is only set if the variable is not defined. If
    you pass an empty flavor using `FLAVOR=` then it remains empty after
    that line.  It can leads to some ports with complicated logic to assume
    the wrong flavor is set.

    PR:             256301
    Reported by:    avg
    Differential Revision:  https://reviews.freebsd.org/D30579

 Mk/bsd.port.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

You are receiving this mail because:
You are on the CC list for the bug.
Received on Tue Jun 01 2021 - 07:18:01 UTC

Original text of this message