[Bug 256187] [NEW-PORT] www/py-django-ckeditor: Django admin CKEditor integration

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 31 Jul 2021 00:16:00 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256187

Kubilay Kocak <koobs_at_FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |maintainer-feedback?(gettok
                   |                            |nowmi_at_yahoo.com)
            Summary|[NEW-PORT]                  |[NEW-PORT]
                   |www/py-django-ckeditor:     |www/py-django-ckeditor:
                   |Django ckeditor version 6   |Django admin CKEditor
                   |                            |integration
           Keywords|                            |needs-patch
                 CC|                            |gettoknowmi_at_yahoo.com
           Severity|Affects Some People         |Affects Only Me

--- Comment #3 from Kubilay Kocak <koobs_at_FreeBSD.org> ---
Review items:

 - Latest upstream version is 6.1.0
 - Add python to CATEGORIES
 - Match COMMENT to upstream description (setup.py:description). "Django admin
CKEditor integration"
 - Match upstream dependency <versions-specs> ("django-js-asset>=1.2.2",)
 - ",run" is incorrect for most python package cases. It excludes "build" ('run
time *only*), which is required to compile py files to pyo pyc counterparts. 
 - Upstream is only testing Python 3.6+, this port declares 3.4+ support. This
isd fine if the packages tests pass with all allowed versions.
 - Upstream ships tests. Add TEST_DEPENDS and a test-target for comprehensive
QA:

Note #1: we don't need to run tox, coverage or lint tests, the following two
should be sufficient:

TEST_ENV+=DJANGO_SETTINGS_MODULE=ckeditor_demo.settings

  ${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py test ckeditor_demo 
  ${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py validate_templates

Note 2: There are a few more dependencies for tests (pillow,
django_extensions). Only add compulsory ones. Interesting to note that these
deps arent in install_requires. Are they 'optional' ? Maybe its worth having
OPTIONS for these.

Confirmation that the port passes tests (portlint, poudriere) would also be
great.

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Sat Jul 31 2021 - 00:16:00 UTC

Original text of this message