[Bug 257421] [NEW PORT] textproc/py-charset-normalizer: Universal Charset Detector. Open, modern alternative to Chardet

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 26 Jul 2021 01:08:47 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257421

Kubilay Kocak <koobs_at_FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
             Status|New                         |Open
                 CC|                            |0xdutra_at_gmail.com,
                   |                            |python_at_FreeBSD.org
              Flags|                            |maintainer-feedback?(0xdutr
                   |                            |a_at_gmail.com)
            Summary|[New Port]                  |[NEW PORT]
                   |textproc/py-charset-normali |textproc/py-charset-normali
                   |zer: Package for encoding & |zer: Universal Charset
                   |language detection          |Detector. Open, modern
                   |                            |alternative to Chardet

--- Comment #1 from Kubilay Kocak <koobs_at_FreeBSD.org> ---
Thank you for submitting a new port Gabriel.

Some review review items:

 - Match upstream short name / summary / show description, modulo portlint
requirements. Suggested COMMENT change is this issues current summary (update
if required).

 - Match USES=python version spec to upstream (setup.py:REQUIRES in this case)

 - Upstream defines no RUN_DEPENDS (install_requires) (setup.py: REQUIRED = [])

Be careful just copying requirements.txt.

Upstream should have this as a test_requirements.txt  and/or (better):
extras_require [ devreqs = { ... , ... } ] so people can just `pip install
charset-normalizer[devreqs]`

 - Upstream defines an extras_require, add an OPTION for this, named
appropriately (the feature it provides)

 - The package provides tests. Add TEST_DEPENDS and do-test target accordingly.

Tip: For pytest based tests, use the following invocation, which overrides any
'extra stuff' set in setup.cfg:[tool:pytest] and other places. This will remove
the need for pycov, in this case:

 do-test:
   _at_cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=

Have a run through our Python Packaging guidelines, and confirm if the test
suite and poudriere tests pass:

  * https://wiki.freebsd.org/Python/PortsPolicy
  https://docs.freebsd.org/en/books/porters-handbook/testing-poudriere.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Mon Jul 26 2021 - 01:08:47 UTC

Original text of this message