[Bug 257664] [NEW PORT] x11/i3lock-color: improved i3lock

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 08 Aug 2021 19:24:35 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257664

Rainer Hurling <rhurlin@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rhurlin@FreeBSD.org

--- Comment #2 from Rainer Hurling <rhurlin@FreeBSD.org> ---
Created attachment 227024
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=227024&action=edit
patch with refinements

Hi Fadel,

Thanks for the patch and the new port. I tried it on CURRENT and it seems to
work quite nice.

Attached you will find an updated patch,  with some smaller and some bigger
changes:

- Add 'SUBDIR += i3lock-color' to x11/Makefile  (for the NEW port!)
- BUILD_DEPENDS=${LOCALBASE}/bin/autoreconf:devel/autoconf not needed
- Reorderd LIB_DEPENDS= (alphabetical)
- Reorderd USES= (alphabetical)
- Add USE_XORG=xinerama xrandr  and delete them from LIB_DEPENDS=
- Removed GH_PROJECT= and GH_TAGNAME=, not necessary because of PORTNAME and
DISTVERSION
- Reorderd some Makefile vars, like wanted by portclippy (from portfmt)


*** Most probably it is also needed to add
'CONFLICTS_INSTALL=i3lock-color-[0-9]*' to x11/i3lock!

Could you please check this for x11/i3lock and test the newest patch and report
back? If the port is ok now, it seems to be ready to commit ;)

Best wishes,
Rainer

-- 
You are receiving this mail because:
You are the assignee for the bug.