[Bug 252186] [NEW PORT] audio/portmidi: Library for real time input and output of MIDI data

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 04 Aug 2021 10:15:02 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252186

--- Comment #3 from Daniel Engberg <daniel.engberg.lists_at_pyret.net> ---
Some quick notes (by no means a full review)

PORTVERSION --> DISTVERSION
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming

MASTER_SITES should use macro
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-distfiles -->
5.4.2.1

DISTNAME should use DISTVERSION
USES= should be sorted in alphabetical order

CFLAGS and LDFLAGS should be replaced by USES= localbase
https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-localbase

Is MAKE_JOBS_UNSAFE really needed?

CMAKE_ARGS+= --> CMAKE_ARGS=

Why is "NO_TEST= Yes" this needed?

While I don't think there's a strict rule it would be nice avoid hosting source
files in tree and preferably have changes upstreamed (files/pm_sndio/pmsndio.c
and files/pm_sndio/pmsndio.h)

audio/portmidi/files/patch-pm__common_CMakeLists.txt and
audio/portmidi/files/patch-pm__dylib_CMakeLists.txt seems to touch unrelated
sections (APPLE)?

Are portlint and/or portfmt happy?

Thanks for your contribution

Best regards,
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Wed Aug 04 2021 - 10:15:02 UTC

Original text of this message