[Bug 257559] net/openldap24-server - refuses to build with ports ssl.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257559

            Bug ID: 257559
           Summary: net/openldap24-server - refuses to build with ports
                    ssl.
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: delphij@FreeBSD.org
          Reporter: robbak@gmail.com
          Assignee: delphij@FreeBSD.org
             Flags: maintainer-feedback?(delphij@FreeBSD.org)

Created attachment 226876
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=226876&action=edit
Patch to fix the logic of the SSL + OPTION FETCH .if statement.

Port refuses to build if ports ssl is in use, regardless of whether OPTION
FETCH is selected. Build error:

===>  Cleaning for openldap-client-2.4.59_1
===>  openldap-client-2.4.59_1 is marked as broken: using OpenSSL from ports
and OPTION FETCH together is not supported.

Options:

            ┌───────────────────────── openldap-client-2.4.59_1
───────────────────────────┐
            │
┌──────────────────────────────────────────────────────────────────────────┐ │  
            │ │ [ ] DEBUG   Build with debugging support                       
         │ │  
            │ │ [x] DOCS    Build and/or install documentation                 
         │ │  
            │ │ [ ] FETCH   Enable fetch(3) support                            
         │ │  
            │ │ [ ] GSSAPI  With GSSAPI support                                
         │ │  
            │
└──────────────────────────────────────────────────────────────────────────┘ │  
           
├──────────────────────────────────────────────────────────────────────────────┤ 
            │                       <  OK  >            <Cancel>               
           │  
           
└──────────────────────────────────────────────────────────────────────────────┘ 

My patch, fixing the logic by adding brackets around all the ssl parts:

index 6146a8c82b34..3b72dc62fd46 100644
--- a/net/openldap24-server/Makefile
+++ b/net/openldap24-server/Makefile
@@ -509,7 +509,7 @@ PLIST_SUB+=         OPENLDAP_MAJOR=${OPENLDAP_MAJOR}

 .include <bsd.port.pre.mk>

-.if ${PORT_OPTIONS:MFETCH} && defined(OPENSSL_INSTALLED) &&
${OPENSSL_INSTALLED} != "" || ${SSL_DEFAULT} != base
+.if ${PORT_OPTIONS:MFETCH} && ( defined(OPENSSL_INSTALLED) &&
${OPENSSL_INSTALLED} != "" || ${SSL_DEFAULT} != basea )
 BROKEN=        using OpenSSL from ports and OPTION FETCH together is not
supported
 . endif

-- 
You are receiving this mail because:
You are the assignee for the bug.