[Bug 290375] bsdinstall: pkgbase not scripted

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 12 Dec 2025 16:41:20 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290375

Alan Somers <asomers@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |asomers@FreeBSD.org

--- Comment #1 from Alan Somers <asomers@FreeBSD.org> ---
This is a good start, but I think there are at least two problems, and maybe
four:

* Testing BSDINSTALL_PKG_REPOS_DIR should use "-n": if [ -n "$..." ]

* "bsdinstall pkgbase" and "bsdinstall distextract" should be mutually
exclusive.  If the script does the former, then it must skip "bsdinstall
checksum" and "bsdinstall pkgbase"

* changing the default value of DISTRIBUTIONS may break existing scripts.  Best
to leave it the same.

* "bsdinstall pkgbase" already does something sensible if
BSDINSTALL_PKG_REPOS_DIR is unset.  So I don't think that you should require
the user to set it.  Rather, to select a pkgbase install, I think you should
either require the user to set DISTRIBUTIONS="", or else introduce a new
variable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.