[Bug 277096] WITHOUT_CLANG does not exclude SANITIZER_SHAREDIR from package file list

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277096

Dimitry Andric <dim@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dim@FreeBSD.org,
                   |                            |emaste@freebsd.org

--- Comment #1 from Dimitry Andric <dim@FreeBSD.org> ---
Hm, I don't see why only libclang_rt.asan-x86_64.so would be left? If you look
at lib/Makefile, it descends into the lib/libclang_rt directory (which produces
all the libclang_rt.* files, and the *_ignore_list.txt files), but it's only
gated on the compiler type:

# The libraries under libclang_rt can only be built by clang.
.if ${COMPILER_TYPE} == "clang"
_libclang_rt=   libclang_rt
.elif (${MK_ASAN} != "no" || ${MK_UBSAN} != "no") && make(all)
.error Requested build with sanitizers but cannot build runtime libraries!
.endif

Ed, would we also need a test for MK_CLANG==no here?


E.g.:

.if ${COMPILER_TYPE} == "clang" && ${MK_CLANG} != "no"
_libclang_rt=   libclang_rt
.elif (${MK_ASAN} != "no" || ${MK_UBSAN} != "no") && make(all)
.error Requested build with sanitizers but cannot build runtime libraries!
.endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.