[Bug 233836] ports-mgmt/pkg : If both -A and -v are passed to 'pkg set', some packages may be skipped.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233836

--- Comment #2 from Stephen Wall <stephen.wall@redcom.com> ---
There don't appear to be any significant changes with the `pkg set -[Av]` code
in the last 12 years, so it's probably still an issue.

It's gotta be the continue(s) here, and it'll also skip whatever the last if()
is doing:

                while (pkgdb_it_next(it, &pkg, loads) == EPKG_OK) {
                        gotone = true;
                        if ((sets & AUTOMATIC) == AUTOMATIC) {
                                pkg_get(pkg, PKG_ATTR_AUTOMATIC, &automatic);
                                if (automatic == newautomatic)
                                        continue;
                                ...
                        }
                        if ((sets & VITAL) == VITAL) {
                                pkg_get(pkg, PKG_ATTR_VITAL, &vital);
                                if (vital == newvital)
                                        continue;
                                ...
                        }
                        if (sets & (ORIGIN|NAME)) {

But at this point, I no longer care, so closing this is fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.