From nobody Thu Sep 23 20:04:48 2021
X-Original-To: freebsd-pf@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3532B17D2522
	for <freebsd-pf@mlmmj.nyi.freebsd.org>; Thu, 23 Sep 2021 20:04:52 +0000 (UTC)
	(envelope-from kp@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4HFmNN12pqz4V2b;
	Thu, 23 Sep 2021 20:04:52 +0000 (UTC)
	(envelope-from kp@FreeBSD.org)
Received: from venus.codepro.be (venus.codepro.be [5.9.86.228])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mx1.codepro.be", Issuer "R3" (verified OK))
	(Authenticated sender: kp)
	by smtp.freebsd.org (Postfix) with ESMTPSA id DE38D25FCE;
	Thu, 23 Sep 2021 20:04:51 +0000 (UTC)
	(envelope-from kp@FreeBSD.org)
Received: by venus.codepro.be (Postfix, authenticated sender kp)
 id B3F6637DF1;
	Thu, 23 Sep 2021 22:04:49 +0200 (CEST)
From: Kristof Provost <kp@FreeBSD.org>
To: =?utf-8?q?=C3=96zkan?= KIRIK <ozkan.kirik@gmail.com>
Cc: freebsd-pf@freebsd.org
Subject: Re: pf label $nr macro expand reproducable bug
Date: Thu, 23 Sep 2021 22:04:48 +0200
X-Mailer: MailMate (1.14r5818)
Message-ID: <9CA646C6-3902-43ED-9E5C-6BA1302B70BB@FreeBSD.org>
In-Reply-To: <CAAcX-AF_S5WrU+hy6WCzuot33+p_LtP6_7HPTFNMSxoevqM35g@mail.gmail.com>
References: <CAAcX-AFmFwyEK4uzK66LoBK2e6W0_-8ZkJju5jAfSYE7wmSjXA@mail.gmail.com>
 <90E32279-76C0-4D81-B209-BE85A181F874@FreeBSD.org>
 <CAAcX-AF_S5WrU+hy6WCzuot33+p_LtP6_7HPTFNMSxoevqM35g@mail.gmail.com>
List-Id: Technical discussion and general questions about packet filter (pf) <freebsd-pf.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-pf
List-Help: <mailto:pf+help@freebsd.org>
List-Post: <mailto:pf@freebsd.org>
List-Subscribe: <mailto:pf+subscribe@freebsd.org>
List-Unsubscribe: <mailto:pf+unsubscribe@freebsd.org>
Sender: owner-freebsd-pf@freebsd.org
X-BeenThere: freebsd-pf@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam: Yes
X-ThisMailContainsUnwantedMimeParts: N

On 22 Sep 2021, at 11:47, =C3=96zkan KIRIK wrote:
> Hi Kristof,
>
> I tried many things and I found the real problem to reproduce the bug.
> Tested with the latest stable/12.
> And also tested with Live CD without installing
> (https://download.freebsd.org/ftp/snapshots/ISO-IMAGES/12.2/FreeBSD-12.=
2-STABLE-amd64-20210916-r370608-disc1.iso).
> The result is same.
>
> My determination is the problem in the rule optimizer of pf. You can
> see the difference with / without ruleset optimization.
> Without ruleset optimization, $nr macro expanding is true. otherwise fa=
lse.
>
Thanks! That=E2=80=99s a useful bit of extra information. I=E2=80=99ll tr=
y to find some time to debug this soon.

Best regards,
Kristof