From nobody Sat Sep 28 09:56:23 2024 X-Original-To: office@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XG2m72190z5X5tF for ; Sat, 28 Sep 2024 09:56:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XG2m70xHtz43g9 for ; Sat, 28 Sep 2024 09:56:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727517383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TrJlPVNgwfwjyJKzxHFnUrLGSA/bGUZnzal5fsDdt00=; b=x7ClVktj5g441jJfVJc2pzReqg0KByXBSDJ7zA+B8D6GCEIxQAZwqglJL/yPIHQldWRk44 Q7PaTafOi7EG4nPOjbOmPYwik5/qFz/0si9uoGiJlHWBF+KJ6CM89PI0Zr+8x3Xw9WkNpl dKBvi1Jc1bEyeMeTiiyIerB677kyBCzZCuyH8qaAWFMniGb7UX4+QWuzQu0k3g8WnRO9J3 Czsy6UTj1I8hBAPESSjSZpGtY15/BFdQlSoYTR42+zwYP3iyxvs9KIynIKsuK43zJSEBK1 Tk2Pwz7L6039pFW1/Yz1nuaWkH2SFKcbkZsqvwPZ9F1PTgeu7mUWy0Gv0Ui8xQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727517383; a=rsa-sha256; cv=none; b=VYIfKNGrW6elQF8JUwQ3yap05sDETzaJO3/rW3ffUsNfUPyaH61y57r15HCp7G5eIFQFCV YhWvWJT5V6albLG6ZkubFRLPketArKJQtV+tTILBNcH9Cb/dulDFm9eVZY2/aNkDiBf9y6 YTWBYsz+yB+ZhvXU9wHhmCEYfSYLyq1H/nTwUxBBbauQx+KVvn2bPqFYOmjl2l1WhBDR9f vKawLJ35/kcL506Y/vDDTAF7yKqMg72PiRaV/Z1MjTIWOpUyQH5BuxklKr8ZqmWxV7sYWq N96RcE0siCztPwfGV8rhJA1vb/BOKCKXaGp13L9lnNDLkSczElebv3On1RKk0g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XG2m66zS3zKp7 for ; Sat, 28 Sep 2024 09:56:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48S9uMr3036186 for ; Sat, 28 Sep 2024 09:56:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48S9uMow036185 for office@FreeBSD.org; Sat, 28 Sep 2024 09:56:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: office@FreeBSD.org Subject: [Bug 281516] graphics/libemf: fix build with libc++ 19 Date: Sat, 28 Sep 2024 09:56:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: office@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Office applications on FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-office List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-office@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281516 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D2b65317363f625eceb125cad5864fd8= 73a66562f commit 2b65317363f625eceb125cad5864fd873a66562f Author: Dimitry Andric AuthorDate: 2024-09-15 11:55:03 +0000 Commit: Dimitry Andric CommitDate: 2024-09-28 09:53:51 +0000 graphics/libemf: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes graphics/libemf to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ libemf.cpp:982:30: note: in instantiation of template class 'std::basic_string' requested here 982 | std::basic_string filename_w( filename, filename + filename_count ); | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared = here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ libemf should really use char16_t for its 16-bit character type, but the code is full of Windows assumptions that WCHAR is unsigned short. Since std::basic_string is no longer available, use std::basic_string instead, and cast the result to the appropriate type for GetEnhMetaFileW(). [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-remov= als PR: 281516 Approved by: maintainer timeout (~2 weeks) MFH: 2024Q3 graphics/libemf/files/patch-libemf_libemf.cpp | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=