Re: if_bridge: unused 'disable' parameter in bridge_stop()

From: Roy Marples <roy_at_marples.name>
Date: Sat, 20 Jun 2026 08:18:47 UTC
From: Zhenlei Huang <zlei.huang@gmail.com>
To: "Aaron Espinoza"<acesp25@freebsd.org>
Cc: <freebsd-net@freebsd.org>
Date: Sat, 20 Jun 2026 07:41:33 +0100
Subject: Re: if_bridge: unused 'disable' parameter in bridge_stop()
 > From git history, the parameter was introduced while importing from NetBSD. 
 >  
 > The purpose of that parameter is to match the requirement of NetBSD's ifnet protocol `ifp->if_stop` , 
 > ``` 
 > ifp->if_stop = bridge_stop; 
 > ``` 
 >  
 > That parameter is not even used in NetBSD, see https://github.com/NetBSD/src/blob/trunk/sys/net/if_bridge.c . 

NetBSD most definitely still uses if_stop
https://github.com/NetBSD/src/blob/ff256e296a0ab1d32dacadd29b55a40b933b3014/sys/net/if.c#L2827

Roy