[Bug 290221] [netlink] default build of /usr/sbin/arp is broken for proxyarp
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 17 Oct 2025 08:23:29 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290221
--- Comment #2 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:
URL:
https://cgit.FreeBSD.org/src/commit/?id=c26d6bf9da013e839d9a696746ea1741569e619e
commit c26d6bf9da013e839d9a696746ea1741569e619e
Author: Andrey V. Elsukov <ae@FreeBSD.org>
AuthorDate: 2025-10-17 07:53:35 +0000
Commit: Andrey V. Elsukov <ae@FreeBSD.org>
CommitDate: 2025-10-17 08:22:36 +0000
arp: fix adding proxy entries for P2P interfaces
The old rtsock implementation used in-kernel workaround to do so.
When route to specified destination address used P2P interface, the
kernel did the search with ifa_ifwithnet() for most suitable network
and then add proxy entry to this interface.
Use similar approach with netlink implementation. We already have
get_ether_addr() function that does almost the same thing as
ifa_ifwithnet(). Use it when we find that destination route uses
P2P interface and then try to guess suitable interface. This should
fix the use of netlink-based arp(8) in mpd5.
Rename get_ether_addr() to get_ifinfo(), since now it is used to find
only ifindex in case when hwaddr is specified by user.
Also make set_nl() and delete_nl() prototype similar to rtsock.
And allow '-i' to be used with '-S', since we already allow the same
for '-s'.
PR: 290221
Reported by: eugen
Reviewed by: eugen
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D53113
usr.sbin/arp/arp.c | 32 ++++++++++++++++++++------------
usr.sbin/arp/arp.h | 9 ++++-----
usr.sbin/arp/arp_netlink.c | 20 ++++++++++++++++----
3 files changed, 40 insertions(+), 21 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.