From nobody Tue Oct 29 09:11:58 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xd4JZ18lTz5bCWQ for ; Tue, 29 Oct 2024 09:11:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xd4JY6QHsz4lFX for ; Tue, 29 Oct 2024 09:11:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730193117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSrlaQ7/jBzUQKL8ZUi4jwwvA2nev0RXiCl9QkrhhEk=; b=Vs3Q3Z57bgDZfLApwlTEFYj/2uf4fdEy2vAfLnwEY8uFC+Au/vR+g3KSqU0waqgU+t/lze dvZ7/TNoU2xKLLgjyD51UwHpnZ1ZGEkv79kKz1Mhj+9rav+QvXRed+N/FhqLqOQP1BVW14 iqmnNEjcgI4wEHWkqackcT+MLYDph6FlwuHW99ECAJ0krwY5k9mX3gueatMmwQbfPQpBSu Ggahix4X3PNoYv+rbDTuhbRQlJTCcz/qGf1+EzcHt4H5xW85NqS1xvXxR+j1boCcNgWDrI +5rTUgpKo14ay7kfw4Y6ckg9pZWzhcQClbbxCF/AM+svpaRwIbPBPqBjMjPoJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730193117; a=rsa-sha256; cv=none; b=h6JASxaAFXn49Z1cVVITrkmJZdS7jVk1QYZEOHmB+B5WS2rQGco5LLD/ka9aL9F/fu7euJ ZqDk6kemlncNo/n2qRNKuJfoP6oaTI+WA0YuBdfT7exoUqRYzHCO0xdXgsIQ9+r8pxvBfY aEmZeptwqjG9EgJm9DaBBaWVGqYjFVNVvBBaPaJ7dA2Bv6Jo+065Fufk9wPaYEvT6F9+m9 TgXTOw16O5m7UVcDvTLlFdu7rg7/djeRm40c/iQ4PeTmMzMZLhCCFVkJ8k38Xjy6Brfeb2 bnHAMB0nkbJfz1peiqZEmEiugd8Iv0bDpgeIy3rQh33J4eXhMLrTjTw6pLb8KA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xd4JY62LfzHfm for ; Tue, 29 Oct 2024 09:11:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49T9Bvdt016987 for ; Tue, 29 Oct 2024 09:11:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49T9Bvas016986 for net@FreeBSD.org; Tue, 29 Oct 2024 09:11:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 173002] [net] data type size problem in if_spppsubr.c Date: Tue, 29 Oct 2024 09:11:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: zlei@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D173002 Zhenlei Huang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zlei@FreeBSD.org --- Comment #5 from Zhenlei Huang --- Actually user space `struct spppreq spr` is not explicitly zeroed [1], so `fuword() / fueword()` can read garbage into kernel space. I guess /sbin/spppcontrol will get error EINVAL occasionally on a 64bit platforms. As this is an old report, not sure if the reporter Jens can confirm this. 1. https://cgit.freebsd.org/src/tree/sbin/spppcontrol/spppcontrol.c?h=3Dstable= /13#n63 --=20 You are receiving this mail because: You are the assignee for the bug.=