From nobody Wed Jan 17 23:30:59 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TFhvm17ZRz572fB for ; Wed, 17 Jan 2024 23:31:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TFhvl51lQz4LCH for ; Wed, 17 Jan 2024 23:30:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1705534259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7jajSjZb3E/pOx8n9kx0nJRVO/tNmJFwj6CBk7GA3o=; b=iVJt7PYFH1we3q7CEtM8/5yBoJN9OxYBTZuleYDi5L5iYsfv7ksgmkhxCtFSDBlJa57Uf6 LhURg0yBG69LmQMvspYrFFvSbll/QK3/jmPYbg0fWAL3MLSDgfTJzGjy+MiXZAX9WpukLV bKKvExNbpq651qcDZsxKfWJV/U6WBrV2otGm4voXLjl+6dYSDMgAuTICY3x7RvNRYmoveL IH2gduZqddA/W2rvEJWlGyN9sZ8JcCd3TU+MibZQL47Q+Bhk8lPPuwZQbmOySaFmUmkmiV nnQVhWjyb7btX4OcA+tvB/hCxQJTkjjCXu+3kJ34kgeZcZCt/IOAncIZFkpFHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1705534259; a=rsa-sha256; cv=none; b=pw5hEQZ6lGbA1gc/WbL41vNFeVlG5q3FA1Dx0G+o0oaKHv9tCJ6Pueo/g4QyjLEO6HfbeV ywrJSYmOhdNU0Qah82EXGAO5D34gfE6p2WFr1EoYvetfy/hqNgNCS6tgP7BFGKT+fjnZrU CgWLcnr8fyDfCPSNl4dty2L8cfZkG6ZrkAO31GEGmP2y7jYGkc2Q4q3O8ANNwIeKZBPdiB WFyY8PBkmAL8cBES9ItKxqawdTQPzrSOhno9DqqX/EGL++rfdOOtlO7TxHwJ2tnpPl9QaT s7v2OL35wl9chXkpy5J1//7hCXJhrhOXI+9NqzPMJ262wczKjkD+zYU/cYvemg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TFhvl47CRzkLY for ; Wed, 17 Jan 2024 23:30:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40HNUx3Y025704 for ; Wed, 17 Jan 2024 23:30:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40HNUxD2025703 for net@FreeBSD.org; Wed, 17 Jan 2024 23:30:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 276363] if_wg: Fix bug in calculate_padding() for the 'p_mtu = 0' case Date: Wed, 17 Jan 2024 23:30:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276363 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db891f61ef538a4e9b4658b4b756635c80= 36a5788 commit b891f61ef538a4e9b4658b4b756635c8036a5788 Author: Aaron LI AuthorDate: 2024-01-17 23:29:23 +0000 Commit: Kyle Evans CommitDate: 2024-01-17 23:29:52 +0000 if_wg: fix erroneous calculation in calculate_padding() for p_mtu =3D= =3D 0 In practice this is harmless; only keepalive packets may realistically = have p_mtu =3D=3D 0, and they'll also have no payload so the math works out = the same either way. Still, let's prefer technical accuracy and calculate the amount of padding needed rather than the padded length... PR: 276363 sys/dev/wg/if_wg.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=