[Bug 280701] FreeBSD-SA-24:05 fix breaks ICMP/ICMP6 states handling in pf firewall (ping, traceroute)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280701

--- Comment #30 from commit-hook@FreeBSD.org ---
A commit in branch releng/13.4 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=7d3a0370c8a3dadad0739ed88fc26536649119c5

commit 7d3a0370c8a3dadad0739ed88fc26536649119c5
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2024-08-12 14:07:35 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2024-08-21 07:44:01 +0000

    pf: fix icmp-in-icmp state lookup

    In 534ee17e6 pf state checking for ICMP(v6) was made stricter. This change
    failed to correctly set the pf_pdesc for ICMP-in-ICMP lookups, resulting in
ICMP
    error packets potentially being dropped incorrectly.
    Specially, it copied the ICMP header into a separate variable, not into the
    pf_pdesc.

    Populate the required pf_pdesc fields for the embedded ICMP packet's state
lookup.

    PR:             280701
    Approved by:    re (cperciva)
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")

    (cherry picked from commit 2da98eef1f352c496ffd458b4c68ddee972bb903)
    (cherry picked from commit 0d8d4cc3ea47f1ee61d749b22b135eb73c7d33cd)

 sys/netpfil/pf/pf.c | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.