[Bug 280097] Warning printed when FIBs are expanded is unhelpful and confusing
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 20 Aug 2024 01:43:32 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280097 --- Comment #15 from Zhenlei Huang <zlei@FreeBSD.org> --- (In reply to Jeremy Cooper from comment #13) > I am reopening this because the main problem was the content of the message, > not problems about when it is displayed. As it stands, the current solution > still retains the CONFUSING wording. Ah, I think the original warning message > WARNING: Adding ifaddrs to all fibs has been turned off by default. Consider tuning net.add_addr_allfibs if needed says exactly what it intends. Please note `Adding ifaddrs to all fibs` is a feature although it is not highlighted in the warning message. I'd admit that `ifaddrs` is more a developer friendly word, it refers to `interface addresses` exactly. > I propose that the warning be changed ever so slightly so that the user can tell > 1. When it was generated (when net.fibs is adjusted) Now only when the first time increasing `net.fibs` and `net.add_addr_allfibs == 0`. > 2. That the warning is a reminder, not the detection of a problem. Emm, the message was introduced to be a WARNING, exactly. And a WARNING does not necessarily mean a problem is detected. In this case it is something important ( a noticeable breaking change ) that user should be aware. (In reply to Jeremy Cooper from comment #14) > Pardon me, that was my old wording. I think I proposed the following in my last round: >+ printf("%s adjusted to %d. REMINDER: " The `adjusted to` is redundant. When doing the tuning ``` # sysctl net.fibs=2 net.fibs: 1 -> 2 ``` The console should print the new value (by default). >+ "Interface addresses are no longer automatically added " >+ "to additional FIBs. Consider setting %s if needed\n", The `additional` is not accurate. If so then what is the current FIB ? I'd prefer keep `tuning`. I think it is more natural. We are tuning a sysctl knob. >+ "net.fibs", >+ num_tables, > "net.add_addr_allfibs"); >+ If you insist then I'd propose to reword `ifaddrs` to `interface addresses`. The message will end up with ``` WARNING: Adding interface addresses to all fibs has been turned off by default. Consider tuning net.add_addr_allfibs if needed ``` Is it clear enough to you ? -- You are receiving this mail because: You are the assignee for the bug.