From nobody Thu Sep 07 07:12:11 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rh9RH5Bh9z4rnNM for ; Thu, 7 Sep 2023 07:12:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rh9RH49VFz4Zkx for ; Thu, 7 Sep 2023 07:12:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694070731; a=rsa-sha256; cv=none; b=OxJjw5dwy2h/qbzD5RtDEiTlWN+zdE5Gx5VaIX7jNFazFamXMx+X1S7DWHWVY4EvCC80PP 3PiUM3nPYqIpiBsMm/Pyp7thSz6FAM3UCqxGPTfl7CxjWEnfPslHYbhuJddLHn5TyJ9gJB /e6CxTgVrNHhHIdV6b48O4kPsfR1KzpizuzPs8i/5pcUbcQZaOHtSTMqCvbqo/EBgjvuVg GGbu2YuU18hmjGSS7jgVPCMOLKI7PPFBdVJN9hYBzOpaJBYCYd0oGMCNWvi3IipU8gou1p uO0/4DUfBYnDa5djbOKrVWk6bPZQhQ8zzzkuI20qMidpSrvhAwlLmnzebm9jqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694070731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NQLdpTokYFQNhRX18jzwVISHJy3ZemLqXUQcV0USC8k=; b=cjWyq+3lwcVowZWL78gwBCv+N0k8xRYuSLx7duGtjZARKkaKG+SOkKizSAIgPtknlDwLo4 ZecEu9vjc7H8nLvuLGPnVqnBKDSvG8x51AMIkZgXQPG3niLbenKrTutk3t4HB5OiZF5KlI ET2j0w7KzcYPIVLYG+JG/0aTSwO0QxPeDgF69usp64w/lSF28UZfmh5BUegjgWpL6LmXwc gKu/ORqz0+1hKuUxqcKp61Xds9RqYAGii8Do5X0LVhYzMzZ9fxwYRITJ8hP3iWOzzn/T3N O5oebK3UanXDtOrAl1fPo0PEa7jt9ihyRxsqzroqwdAiAVq8IAPJo0+8CMvJEQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rh9RH3FNrzqTH for ; Thu, 7 Sep 2023 07:12:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3877CBC6094173 for ; Thu, 7 Sep 2023 07:12:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3877CBjh094148 for net@FreeBSD.org; Thu, 7 Sep 2023 07:12:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 273559] [iflib] numa allocation Date: Thu, 07 Sep 2023 07:12:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: zlei@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273559 Zhenlei Huang changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zlei@FreeBSD.org --- Comment #1 from Zhenlei Huang --- (In reply to Konrad from comment #0) The lagg(4) has no changes related to NUMA since Nov 19 2021. From the logic in `sys/net/if_lagg.c`:=20 ``` struct lagg_port * lacp_select_tx_port(struct lagg_softc *sc, struct mbuf *m, int *err) { struct lacp_softc *lsc =3D LACP_SOFTC(sc); uint32_t hash; uint8_t numa_domain; if ((sc->sc_opts & LAGG_OPT_USE_FLOWID) && M_HASHTYPE_GET(m) !=3D M_HASHTYPE_NONE) hash =3D m->m_pkthdr.flowid >> sc->flowid_shift; else hash =3D m_ether_tcpip_hash(sc->sc_flags, m, lsc->lsc_hashk= ey); numa_domain =3D m->m_pkthdr.numa_domain; return (lacp_select_tx_port_by_hash(sc, hash, numa_domain, err)); } ``` I guess `numa_domain` in mbuf packet header is not set correctly. That shou= ld be done in driver IIUC. I do not have NUMA devices, can you please share the debug info for `m->m_pkthdr.numa_domain` ? --=20 You are receiving this mail because: You are the assignee for the bug.=