From nobody Fri Sep 01 23:07:01 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rctvr1Nhpz4rsM3 for ; Fri, 1 Sep 2023 23:07:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rctvr0N9kz3CwJ for ; Fri, 1 Sep 2023 23:07:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693609624; a=rsa-sha256; cv=none; b=f5NlFzDLKDuXiBRtLd2FPpc25dHVX5LfdYTqlFmna1YvIs6AT/xZyAfhdaqUyQBVmDLoms bblj0/AdIgLXznYlz9EqjZze+09ues8xL14uE5PZCF7WLi7jBqeOuQOd7DR9qQSjW4p4Ho l/f/HRaeLLGprk6xMbUzEmi+6dcz6P0D50DB3H6KgooSB4OFsSc+g6tYEX60rTw1IKQrHp RGqWPC9BmE7Ni4uiR8BVIPCsGOowkXvul03CpuPTe0G9JnBJKpVhA/s447n6w7oK3oyRR/ SvjQTZM4RqpbKrLoZLQ8dcQzakqfcFnGzBR+Y8tO+j1TzZSudaE13OUznAuXYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693609624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e+HRKLNN9JT4DFp1UzuSCFCbtlfSwyqdwKaM9XR7TBI=; b=cUhXUq10e/9uhnl6jBSnuRV4AHKzglzzRAGKdWq9liRhXDeoQOa5u2G78n5whuSAm+Ljen X5JV91R3Gvqj0W3rVfUT+j012yblJ3Ht3fYfGc7Z4olScJfzMuSDTFIxY19c8CB7qc1rjq HVz7lWRj0IaKZ8O0Ab5zvvn0lrX4sbzMRYRxsg2/icV115cVm/EvbZp51uNFf9JdgDOaRr 1xt3Q89P7qv9uNfbRWLBKAdGbkonm5NX0mV1wksuJJpkhci6YF5EGI5Sgo26f9op4FeYPA nrj+5HE9ShVzUxESjvyDe2Zct7L55eM75rhn2OsHp9W5ru5oHnfYAK6KJlOadA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rctvq6YyCz4rl for ; Fri, 1 Sep 2023 23:07:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 381N73IO090069 for ; Fri, 1 Sep 2023 23:07:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 381N73kP090068 for net@FreeBSD.org; Fri, 1 Sep 2023 23:07:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 221122] Attaching interface to a bridge stops all traffic on uplink NIC for few seconds Date: Fri, 01 Sep 2023 23:07:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: spork@bway.net X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221122 --- Comment #35 from spork@bway.net --- OK, really done for now... :) I'm trying this out for a bit. [root@clweb5 /usr/src/sys/net]# diff -u if_bridge.c.dist if_bridge.c.caps --- if_bridge.c.dist 2023-08-31 22:47:16.758453000 -0400 +++ if_bridge.c.caps 2023-09-01 19:05:41.724323000 -0400 @@ -452,6 +452,13 @@ CTLFLAG_RWTUN | CTLFLAG_VNET, &VNET_NAME(log_stp), 0, "Log STP state changes"); +/* restore member if capabilites */ +VNET_DEFINE_STATIC(int, restore_caps) =3D 1; +#define V_restore_caps VNET(restore_caps) +SYSCTL_INT(_net_link_bridge, OID_AUTO, restore_caps, + CTLFLAG_RWTUN | CTLFLAG_VNET, &VNET_NAME(restore_caps), 0, + "Restore member interface flags on reinit"); + /* share MAC with first bridge member */ VNET_DEFINE_STATIC(int, bridge_inherit_mac); #define V_bridge_inherit_mac VNET(bridge_inherit_mac) @@ -1151,7 +1158,8 @@ #endif break; } - /* reneable any interface capabilities */ + /* reneable any interface capabilities if restore_caps is s= et */ + if (V_restore_caps) bridge_set_ifcap(sc, bif, bif->bif_savedcaps); } bstp_destroy(&bif->bif_stp); /* prepare to free */ --=20 You are receiving this mail because: You are the assignee for the bug.=