From nobody Fri Sep 01 02:40:09 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RcMh96hnFz4rw99 for ; Fri, 1 Sep 2023 02:40:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RcMh94T1rz4KhS for ; Fri, 1 Sep 2023 02:40:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693536009; a=rsa-sha256; cv=none; b=s5bjOf5fnKVWDCYBTC+1sm5h4zdFpPHQEmyahn4RzHtSVeN+drL7rJf3kgIv+/rJfYk9Sg HhdVGwzzoDnZK14lAN8WACwmUbE8F7ggFtCOnjay+fUbq2/9ECUnEHdN5T91CE/X+/0d9N JNKphMMuIPDiG9fOT8gFg1xnU8S6DHJv4MNzUrINRZtFCvwAWIAe9uVxTq4+WcEejmBhDI Fhc/W15NpsJn3NVIDbznH/5KgCuJhIKcXUhrp8rVEmTafHQ0v49k2AlZ08wJnOZ52R+krP fvXQHOutEURBBWjfgmWH+WciQGOEuYRLYPX4ZPJAJpfINj4dvS9RLFqNMCyvcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693536009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=atFhh+Y/OZjI6TMrTkf+1Cg2GoxT9RcLl9m6WxqPkdU=; b=rxGZI+UlQzTdiOw4wfR5uzsZwGnDimRJj/+xauQO/Qr7yLMspwssrOpvOW+QemuRcgy/TS 5TNA6Ug8KvUBP+hTmOSexsbzDWaqo82JRl1H+LM6c3NLHXUUJmrOXarPcOIrficY5/LHwE IkQ2pQyblZ0SRmaDpoXcvAJ1A2FeB4r+SWzKDyriY9pLbmierRrAn8ujR2bHxDxQtwCqF5 tcE3KRihQhsOS8Oy5bfN/NXx3CGkfealX/3QjudE1WdF5LeQgzuwGIREQUcRSm1JMWEd1s CeTjMRyHHfsXTTcxeeGd6Yqhx8kOc7JbODygtDgO6RlVrK2Gpu+osNjrUE2n/A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RcMh93RFVzjs2 for ; Fri, 1 Sep 2023 02:40:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3812e9lR040648 for ; Fri, 1 Sep 2023 02:40:09 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3812e9Vx040647 for net@FreeBSD.org; Fri, 1 Sep 2023 02:40:09 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 221122] Attaching interface to a bridge stops all traffic on uplink NIC for few seconds Date: Fri, 01 Sep 2023 02:40:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: spork@bway.net X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221122 --- Comment #34 from spork@bway.net --- The answer to "when did interface capabilities get restored when a member is removed" is "back in 2008". This commit altered how interface flags were dealt with:=20 https://cgit.freebsd.org/src/commit/sys/net/if_bridge.c?id=3Dec29c623005ca6= a32d44fb59bc2a759a96dc75e4 You can see a variable "bif_savedcaps" was added so that the bridge now tra= cks what the original interface flags were. Then when a member is removed, it looks like all of a bridge's interfaces a= re looped through and the original flags are restored (in bridge_delete_member= ()): + /* reneable any interface capabilities */ + bridge_set_ifcap(sc, bif, bif->bif_savedcaps); Not sure where, but this kind of feels like it could be a tunable, like "net.link.bridge.restore_caps" or similar, given a) jails will trigger this with lots of NICs b) these days 5 seconds of downtime is actually not a min= or issue in many environments and c) it need not change any defaults, but rc.d/jail and 3rd party jail scripts could opt to set it d) jails are kind = of a big reason people come to FreeBSD. I'm not much of a coder, but I could get that sysctl like 80% there I think after looking at the other "net.link.bridge" tunables... any takers on help= ing? Any thoughts on whether this makes sense? --=20 You are receiving this mail because: You are the assignee for the bug.=