From nobody Mon Mar 27 08:17:36 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PlQfS69qPz41x0V for ; Mon, 27 Mar 2023 08:17:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PlQfS4YXrz4F0M for ; Mon, 27 Mar 2023 08:17:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679905056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i1nsxCxyJl5qeC7F5NsrBPvGgek6m2TnlDIJZdwJKx0=; b=pskw2O9B5H+Ksdfr+jZs6TkgSeRHjwTRwHyvoO3bXrYQ9mFjtRyo8NeLZ3lM3JDWafqN+f il7yQD+0td+vKJht24/UW79hD/qhbFEcpOpMuKxA2I0mYNmA0g9pttFqsP/SlFvE1nYO2y takA1GQ0/VnXwx4o3TuDscY+EZgRCdQH968ec0t/OspDEKJpsnNSIMLhwcD3E/AXYAn400 4/NCMWFBrsSuKJrXDASURN+muyf6fdPyhWipL7VgERPMZwDR0DHf/fWZwre3Gc0UXj/VR9 UYrmHI5qsi1OGV4WJGdwAJcCJ7ZvoJ74JKWdyKw9EzwPigmknrJmDqJ8aq/PzA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679905056; a=rsa-sha256; cv=none; b=M3YDm2l5GgE8WMCD/oppnCakREWRhw6eL81un3iYyH4CJLRrwwgd7R2yxy+yParxex/KXc NBXOWUh6JgmT9gb0vWht/JB0mWB/oS0Ek3+t/P8/B3lz6IC9SOK3t9YpOP5AciK2LKttdn MeKNm+rDdxqWCfFSuDRURYilFTKpwcp2ok2acbyNhPI27r5yCL4HeXC2rITvj8HFnO2Pxi yjuRkoZbfuoqKbQxBRxdP6ZSY31VveJPKvBhgnw/KOknLv0PKoUp/8LSWC3Gf8vD9HxvrM muk5/CQaCNns+MmqJOxSLWyxXY0gt/db7fpslvEjGkVVtRX/Uyh6Qvk/TTADFQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PlQfS3NhxzF3W for ; Mon, 27 Mar 2023 08:17:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32R8Ha4b017199 for ; Mon, 27 Mar 2023 08:17:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32R8HamA017198 for net@FreeBSD.org; Mon, 27 Mar 2023 08:17:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 268246] crash and panic using pfsync on 13.1-RELEASE Date: Mon, 27 Mar 2023 08:17:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D268246 --- Comment #100 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D09b7cab88f652e3a3682749e38c043d25= dd7d0ed commit 09b7cab88f652e3a3682749e38c043d25dd7d0ed Author: Kristof Provost AuthorDate: 2023-03-20 13:29:55 +0000 Commit: Kristof Provost CommitDate: 2023-03-27 00:28:32 +0000 pfsync: fix pfsync_undefer_state() locking pfsync_undefer_state() takes the bucket lock, but could get called from places (e.g. from pfsync_update_state() or pfsync_delete_state()) where we already held the lock. As it can also be called from places where we don't yet hold the lock create new locked variant for use when the lock is already held. Keep using pfsync_undefer_state() where the lock must still be taken. PR: 268246 MFC after: 1 week Sponsored by: Rubicon Communications, LLC (Netgate) (cherry picked from commit 53247cdf12449e90f6736ae563e4cce8315c923f) sys/netpfil/pf/if_pfsync.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=